Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(844)

Unified Diff: native_client_sdk/src/libraries/nacl_io/kernel_object.cc

Issue 565763002: Plumbing though mode parameter to open, since fusefs can make use of it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: native_client_sdk/src/libraries/nacl_io/kernel_object.cc
diff --git a/native_client_sdk/src/libraries/nacl_io/kernel_object.cc b/native_client_sdk/src/libraries/nacl_io/kernel_object.cc
index 853947fc9296baf13cbd6bf14115f495d8a99688..c9f3f2efc971e8de6f3def9bde5a79bba3adfdcc 100644
--- a/native_client_sdk/src/libraries/nacl_io/kernel_object.cc
+++ b/native_client_sdk/src/libraries/nacl_io/kernel_object.cc
@@ -99,7 +99,7 @@ Error KernelObject::AcquireFsAndRelPath(const std::string& path,
// Given a path, acquire the associated filesystem and node, creating the
// node if needed based on the provided flags.
Error KernelObject::AcquireFsAndNode(const std::string& path,
- int oflags,
+ int oflags, mode_t mflags,
ScopedFilesystem* out_fs,
ScopedNode* out_node) {
Path rel_parts;
@@ -109,7 +109,7 @@ Error KernelObject::AcquireFsAndNode(const std::string& path,
if (error)
return error;
- error = (*out_fs)->Open(rel_parts, oflags, out_node);
+ error = (*out_fs)->OpenWithMode(rel_parts, oflags, mflags, out_node);
if (error)
return error;
@@ -143,7 +143,7 @@ Error KernelObject::SetCWD(const std::string& path) {
ScopedFilesystem fs;
ScopedNode node;
- Error error = AcquireFsAndNode(abs_path, O_RDONLY, &fs, &node);
+ Error error = AcquireFsAndNode(abs_path, O_RDONLY, 0, &fs, &node);
if (error)
return error;

Powered by Google App Engine
This is Rietveld 408576698