Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: native_client_sdk/src/libraries/nacl_io/filesystem.h

Issue 565763002: Plumbing though mode parameter to open, since fusefs can make use of it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: native_client_sdk/src/libraries/nacl_io/filesystem.h
diff --git a/native_client_sdk/src/libraries/nacl_io/filesystem.h b/native_client_sdk/src/libraries/nacl_io/filesystem.h
index 8194100f95a0b61b9841ad2f87ad745be9444fb4..0b2034044523b24337c6c1956de2d700428ae958 100644
--- a/native_client_sdk/src/libraries/nacl_io/filesystem.h
+++ b/native_client_sdk/src/libraries/nacl_io/filesystem.h
@@ -62,12 +62,20 @@ class Filesystem : public sdk_util::RefObject {
// All paths in functions below are expected to containing a leading "/".
+ // Open a node at |path| with the specified open and modeflags. The resulting
+ // Node is created with a ref count of 1.
+ // Assumes that |out_node| is non-NULL.
+ virtual Error OpenWithMode(const Path& path,
+ int open_flags,
+ mode_t mode_flags,
+ ScopedNode* out_node) = 0;
+
// Open a node at |path| with the specified open flags. The resulting
// Node is created with a ref count of 1.
// Assumes that |out_node| is non-NULL.
virtual Error Open(const Path& path,
binji 2014/09/11 23:51:40 make this non-virtual, since it is just a helper f
bradn 2014/09/12 06:17:03 Done.
int open_flags,
- ScopedNode* out_node) = 0;
+ ScopedNode* out_node);
// OpenResource is only used to read files from the NaCl NMF file. No
// filesystem except PassthroughFs should implement it.

Powered by Google App Engine
This is Rietveld 408576698