Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(971)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 565743002: Remove most usages of guava. (Closed)

Created:
6 years, 3 months ago by nyquist
Modified:
6 years, 3 months ago
CC:
chromium-reviews, zea+watch_chromium.org, browser-components-watch_chromium.org, dmazzoni+watch_chromium.org, Ilya Sherman, tim+watch_chromium.org, benquan, jam, darin-cc_chromium.org, android-webview-reviews_chromium.org, dyu1, haitaol+watch_chromium.org, timvolodine, yuzo+watch_chromium.org, Michael van Ouwerkerk, rouslan+autofillwatch_chromium.org, maniscalco+watch_chromium.org, plundblad+watch_chromium.org, riju_, aboxhall+watch_chromium.org, Dane Wallinga, dtseng+watch_chromium.org, estade+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove most usages of guava. This CL removes most usages of the guava library. TBR=thakis@chromium.org,brettw@chromium.org,yfriedman@chromium.org BUG=412673 Committed: https://crrev.com/56f97b71a4a88d7d016fcf4b1b3d37bc56691e35 Cr-Commit-Position: refs/heads/master@{#294620}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -88 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 1 chunk +1 line, -2 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwContentsClientCallbackHelper.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwScrollOffsetManager.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwSettings.java View 1 chunk +1 line, -2 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegate.java View 1 chunk +1 line, -2 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/ExternalVideoSurfaceContainer.java View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProvider.java View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/JavascriptAppModalDialog.java View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuHandler.java View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogControllerAndroid.java View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuHelper.java View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/identity/SettingsSecureBasedIdentificationGenerator.java View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/identity/UniqueIdentificationGeneratorFactory.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/identity/UuidBasedUniqueIdentificationGenerator.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/invalidation/InvalidationController.java View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/AutocompleteController.java View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxSuggestion.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/signin/OAuth2TokenService.java View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/sync/ChromiumSyncAdapter.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/sync/DelayedSyncController.java View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/EmptyTabModel.java View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/widget/accessibility/AccessibilityTabModelListItem.java View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/sync/DelayedSyncControllerTest.java View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M content/content.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/android/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/BatteryStatusManager.java View 1 chunk +1 line, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/BindingManagerImpl.java View 1 chunk +1 line, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/BrowserStartupController.java View 1 1 chunk +1 line, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java View 1 chunk +1 line, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java View 1 chunk +1 line, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/DeviceSensors.java View 1 chunk +1 line, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/LocationProviderAdapter.java View 1 chunk +1 line, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/LocationProviderFactory.java View 1 chunk +1 line, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/MediaResourceGetter.java View 1 chunk +1 line, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ScreenOrientationListener.java View 1 chunk +1 line, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java View 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java View 1 chunk +1 line, -2 lines 0 comments Download
M sync/android/java/src/org/chromium/sync/internal_api/pub/base/ModelType.java View 1 chunk +1 line, -1 line 0 comments Download
M sync/android/java/src/org/chromium/sync/notifier/InvalidationIntentProtocol.java View 2 chunks +4 lines, -3 lines 0 comments Download
M sync/android/java/src/org/chromium/sync/notifier/InvalidationPreferences.java View 2 chunks +5 lines, -2 lines 0 comments Download
M sync/android/java/src/org/chromium/sync/notifier/InvalidationService.java View 2 chunks +1 line, -1 line 0 comments Download
M sync/android/java/src/org/chromium/sync/notifier/SyncStatusHelper.java View 1 chunk +1 line, -2 lines 0 comments Download
M sync/android/java/src/org/chromium/sync/signin/AccountManagerHelper.java View 1 chunk +1 line, -2 lines 0 comments Download
M sync/android/java/src/org/chromium/sync/signin/ChromeSigninController.java View 1 chunk +1 line, -1 line 0 comments Download
M sync/sync_android.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 25 (11 generated)
nyquist
boliu: android_webview jdduke: content aurimas: chrome and sync
6 years, 3 months ago (2014-09-11 20:44:23 UTC) #2
jdduke (slow)
On 2014/09/11 20:44:23, nyquist wrote: > boliu: android_webview > jdduke: content > aurimas: chrome and ...
6 years, 3 months ago (2014-09-11 20:50:56 UTC) #3
aurimas (slooooooooow)
lgtm https://chromiumcodereview.appspot.com/565743002/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/sync/DelayedSyncControllerTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/sync/DelayedSyncControllerTest.java (right): https://chromiumcodereview.appspot.com/565743002/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/sync/DelayedSyncControllerTest.java#newcode101 chrome/android/javatests/src/org/chromium/chrome/browser/sync/DelayedSyncControllerTest.java:101: static void sendChromeToBackground(Activity activity) throws InterruptedException { Why ...
6 years, 3 months ago (2014-09-11 20:55:12 UTC) #4
nyquist
thakis: TBR chrome/chrome.gyp brettw: TBR content/content.gyp yfriedman: TBR content/public/android/BUILD.gn https://chromiumcodereview.appspot.com/565743002/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/sync/DelayedSyncControllerTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/sync/DelayedSyncControllerTest.java (right): https://chromiumcodereview.appspot.com/565743002/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/sync/DelayedSyncControllerTest.java#newcode101 chrome/android/javatests/src/org/chromium/chrome/browser/sync/DelayedSyncControllerTest.java:101: ...
6 years, 3 months ago (2014-09-11 22:09:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/565743002/1
6 years, 3 months ago (2014-09-11 22:24:12 UTC) #10
boliu
android_webview lgtm
6 years, 3 months ago (2014-09-11 22:24:45 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/11813)
6 years, 3 months ago (2014-09-12 02:03:00 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/565743002/1
6 years, 3 months ago (2014-09-12 06:18:50 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/11891)
6 years, 3 months ago (2014-09-12 06:30:59 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/565743002/1
6 years, 3 months ago (2014-09-12 15:00:01 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/11986)
6 years, 3 months ago (2014-09-12 15:33:44 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/565743002/20001
6 years, 3 months ago (2014-09-12 17:10:19 UTC) #23
commit-bot: I haz the power
Committed patchset #2 (id:20001) as c3e8544a8132c63aab067f87af337888f0919988
6 years, 3 months ago (2014-09-12 18:49:30 UTC) #24
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 18:53:50 UTC) #25
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/56f97b71a4a88d7d016fcf4b1b3d37bc56691e35
Cr-Commit-Position: refs/heads/master@{#294620}

Powered by Google App Engine
This is Rietveld 408576698