Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 565723002: Revert of CSP: Convert CSPSource constructor bools into a enum. (Closed)

Created:
6 years, 3 months ago by jianli
Modified:
6 years, 3 months ago
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Revert of CSP: Convert CSPSource constructor bools into a enum. (patchset #1 id:1 of https://codereview.chromium.org/568433002/) Reason for revert: Your patch broke quite a number of webkit tests: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.8%20%28retina%29/builds/19050 http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.7/builds/31462 Original issue's description: > CSP: Convert CSPSource constructor bools into a enum. > > Rather than passing the wildcard disposition of CSPSource's hosts and ports > as booleans, we should have an enum that allows us to figure out hat we > mean at the callsite. This patch adds CSPSource::WildcardDisposition in > order to make this clear. > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181821 TBR=jochen@chromium.org,mkwst@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181833

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -34 lines) Patch
M Source/core/frame/csp/CSPSource.h View 2 chunks +3 lines, -8 lines 0 comments Download
M Source/core/frame/csp/CSPSource.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/frame/csp/CSPSourceList.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/frame/csp/CSPSourceList.cpp View 9 chunks +16 lines, -16 lines 0 comments Download
M Source/core/frame/csp/ContentSecurityPolicy.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jianli
Created Revert of CSP: Convert CSPSource constructor bools into a enum.
6 years, 3 months ago (2014-09-11 17:24:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/565723002/1
6 years, 3 months ago (2014-09-11 17:25:28 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 181833
6 years, 3 months ago (2014-09-11 17:25:56 UTC) #3
jianli
6 years, 3 months ago (2014-09-11 18:49:12 UTC) #4
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/563863002/ by jianli@chromium.org.

The reason for reverting is: Not a culprit..

Powered by Google App Engine
This is Rietveld 408576698