Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 565713004: Linux sandbox: Remove CodeGen::JoinInstructions. (Closed)

Created:
6 years, 3 months ago by rickyz (no longer on Chrome)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Linux sandbox: Remove CodeGen::JoinInstructions. Recent refactoring has made this function unnecessary. BUG=414363 Committed: https://crrev.com/91577b8fe31f32ad6a5fcbf30632e30d80278854 Cr-Commit-Position: refs/heads/master@{#295423}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -65 lines) Patch
M sandbox/linux/seccomp-bpf/codegen.h View 1 2 chunks +9 lines, -16 lines 0 comments Download
M sandbox/linux/seccomp-bpf/codegen.cc View 1 2 chunks +1 line, -32 lines 0 comments Download
M sandbox/linux/seccomp-bpf/codegen_unittest.cc View 1 2 chunks +15 lines, -17 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
mdempsky
On 2014/09/16 23:12:47, Ricky Zhou wrote: > mailto:rickyz@google.com changed reviewers: > + mailto:jln@chromium.org, mailto:mdempsky@chromium.org Hey ...
6 years, 3 months ago (2014-09-17 16:35:07 UTC) #2
rickyz (no longer on Chrome)
Oops, didn't realize I needed to publish+mail, thanks for catching this, mdempsky!
6 years, 3 months ago (2014-09-17 17:42:08 UTC) #3
mdempsky
lgtm
6 years, 3 months ago (2014-09-18 04:56:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/565713004/20001
6 years, 3 months ago (2014-09-18 04:56:58 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 5911425b68e593d3587b16091e7f9d3736d4653e
6 years, 3 months ago (2014-09-18 05:58:02 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 05:58:45 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/91577b8fe31f32ad6a5fcbf30632e30d80278854
Cr-Commit-Position: refs/heads/master@{#295423}

Powered by Google App Engine
This is Rietveld 408576698