Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 565673006: Revise update-w3c-deps to check in tests directly (Closed)

Created:
6 years, 3 months ago by Dirk Pranke
Modified:
6 years, 3 months ago
Reviewers:
eseidel
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

As discussed on blink-dev, we will start checking in the imported w3c tests directly. This is patchset 1 of 4 in making that happen. This patch changes update-w3c-deps to do the import. Tests will now be imported into the "LayoutTests/imported" directory, to avoid any conflicts with the old git repos. This patch significantly reworks update-w3c-deps, and patches webkitpy.test_importer to remove the import logs, make logging work better during the import, and handle skipping subdirs properly when not importing in place. This patch also adds an exit() method to the SystemHost class to remove one more reason for importing sys. TBR=eseidel@chromium.org BUG=413454 BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181860

Patch Set 1 : patch for review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+340 lines, -327 lines) Patch
M LayoutTests/W3CImportExpectations View 1 chunk +132 lines, -132 lines 0 comments Download
M Tools/Scripts/update-w3c-deps View 1 chunk +9 lines, -136 lines 0 comments Download
M Tools/Scripts/webkitpy/common/system/systemhost.py View 1 chunk +3 lines, -0 lines 0 comments Download
A Tools/Scripts/webkitpy/w3c/deps_updater.py View 1 chunk +179 lines, -0 lines 0 comments Download
M Tools/Scripts/webkitpy/w3c/test_importer.py View 8 chunks +17 lines, -59 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Dirk Pranke
clean up update-w3c-deps
6 years, 3 months ago (2014-09-11 22:09:34 UTC) #1
Dirk Pranke
6 years, 3 months ago (2014-09-11 23:01:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/565673006/40001
6 years, 3 months ago (2014-09-11 23:02:27 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 00:19:28 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:40001) as 181860

Powered by Google App Engine
This is Rietveld 408576698