chrome/browser/ui/passwords/manage_passwords_ui_controller.cc - Issue 565673002: Close the password bubble when navigating between tabs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

Issue 565673002: Close the password bubble when navigating between tabs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix Android Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_ui_controller.h ('k') | chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

diff --git a/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc b/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

index 899edd95ce88a711383c0d4ac857e00b7a926b5d..df2cc29426a3d1cfb0173e046923df358c2da9d7 100644

--- a/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

+++ b/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

@@ -9,6 +9,7 @@

#include "chrome/browser/chrome_notification_types.h"

#include "chrome/browser/password_manager/password_store_factory.h"

#include "chrome/browser/ui/browser_command_controller.h"

+#include "chrome/browser/ui/browser_dialogs.h"

#include "chrome/browser/ui/browser_finder.h"

#include "chrome/browser/ui/browser_window.h"

#include "chrome/browser/ui/chrome_pages.h"

@@ -239,6 +240,12 @@ void ManagePasswordsUIController::DidNavigateMainFrame(

timer_.reset(new base::ElapsedTimer());

}

+void ManagePasswordsUIController::WasHidden() {

+#if !defined(OS_ANDROID)

+ chrome::CloseManagePasswordsBubble(web_contents());

+#endif

const autofill::PasswordForm& ManagePasswordsUIController::

PendingCredentials() const {

DCHECK(form_manager_);