Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: chrome/browser/ui/passwords/manage_passwords_ui_controller.h

Issue 565673002: Close the password bubble when navigating between tabs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix Android Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_ 5 #ifndef CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_
6 #define CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_ 6 #define CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_
7 7
8 #include "base/gtest_prod_util.h" 8 #include "base/gtest_prod_util.h"
9 #include "base/memory/scoped_vector.h" 9 #include "base/memory/scoped_vector.h"
10 #include "base/timer/elapsed_timer.h" 10 #include "base/timer/elapsed_timer.h"
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
106 106
107 // The pieces of saving and blacklisting passwords that interact with 107 // The pieces of saving and blacklisting passwords that interact with
108 // FormManager, split off into internal functions for testing/mocking. 108 // FormManager, split off into internal functions for testing/mocking.
109 virtual void SavePasswordInternal(); 109 virtual void SavePasswordInternal();
110 virtual void NeverSavePasswordInternal(); 110 virtual void NeverSavePasswordInternal();
111 111
112 // content::WebContentsObserver: 112 // content::WebContentsObserver:
113 virtual void DidNavigateMainFrame( 113 virtual void DidNavigateMainFrame(
114 const content::LoadCommittedDetails& details, 114 const content::LoadCommittedDetails& details,
115 const content::FrameNavigateParams& params) OVERRIDE; 115 const content::FrameNavigateParams& params) OVERRIDE;
116 virtual void WasHidden() OVERRIDE;
116 117
117 // We create copies of PasswordForm objects that come in with unclear lifetime 118 // We create copies of PasswordForm objects that come in with unclear lifetime
118 // and store them in this vector as well as in |password_form_map_| to ensure 119 // and store them in this vector as well as in |password_form_map_| to ensure
119 // that we destroy them correctly. If |new_password_forms_| gets cleared then 120 // that we destroy them correctly. If |new_password_forms_| gets cleared then
120 // |password_form_map_| is to be cleared too. 121 // |password_form_map_| is to be cleared too.
121 ScopedVector<autofill::PasswordForm> new_password_forms_; 122 ScopedVector<autofill::PasswordForm> new_password_forms_;
122 123
123 // All previously stored credentials for a specific site. 124 // All previously stored credentials for a specific site.
124 // Protected, not private, so we can mess with the value in 125 // Protected, not private, so we can mess with the value in
125 // ManagePasswordsUIControllerMock. 126 // ManagePasswordsUIControllerMock.
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
161 162
162 // The origin of the form we're currently dealing with; we'll use this to 163 // The origin of the form we're currently dealing with; we'll use this to
163 // determine which PasswordStore changes we should care about when updating 164 // determine which PasswordStore changes we should care about when updating
164 // |password_form_map_|. 165 // |password_form_map_|.
165 GURL origin_; 166 GURL origin_;
166 167
167 DISALLOW_COPY_AND_ASSIGN(ManagePasswordsUIController); 168 DISALLOW_COPY_AND_ASSIGN(ManagePasswordsUIController);
168 }; 169 };
169 170
170 #endif // CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_ 171 #endif // CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698