Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Side by Side Diff: chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_cocoa.mm

Issue 565673002: Close the password bubble when navigating between tabs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix Android Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_cocoa.h" 5 #import "chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_cocoa.h"
6 6
7 #include "base/mac/scoped_block.h" 7 #include "base/mac/scoped_block.h"
8 #include "chrome/browser/ui/browser_dialogs.h" 8 #include "chrome/browser/ui/browser_dialogs.h"
9 #include "chrome/browser/ui/browser_finder.h" 9 #include "chrome/browser/ui/browser_finder.h"
10 #import "chrome/browser/ui/cocoa/browser_window_controller.h" 10 #import "chrome/browser/ui/cocoa/browser_window_controller.h"
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 } 57 }
58 BrowserWindowController* bwc = 58 BrowserWindowController* bwc =
59 [BrowserWindowController browserWindowControllerForWindow:window]; 59 [BrowserWindowController browserWindowControllerForWindow:window];
60 ManagePasswordsBubbleCocoa::ShowBubble( 60 ManagePasswordsBubbleCocoa::ShowBubble(
61 webContents, 61 webContents,
62 password_manager::ui::IsAutomaticDisplayState(controller->state()) 62 password_manager::ui::IsAutomaticDisplayState(controller->state())
63 ? ManagePasswordsBubble::AUTOMATIC 63 ? ManagePasswordsBubble::AUTOMATIC
64 : ManagePasswordsBubble::USER_ACTION, 64 : ManagePasswordsBubble::USER_ACTION,
65 [bwc locationBarBridge]->manage_passwords_decoration()->icon()); 65 [bwc locationBarBridge]->manage_passwords_decoration()->icon());
66 } 66 }
67
68 void CloseManagePasswordsBubble(content::WebContents* web_contents) {
69 // The bubble is closed when it loses the focus.
70 }
67 } // namespace chrome 71 } // namespace chrome
68 72
69 ManagePasswordsBubbleCocoa::ManagePasswordsBubbleCocoa( 73 ManagePasswordsBubbleCocoa::ManagePasswordsBubbleCocoa(
70 content::WebContents* webContents, 74 content::WebContents* webContents,
71 DisplayReason displayReason, 75 DisplayReason displayReason,
72 ManagePasswordsIcon* icon) 76 ManagePasswordsIcon* icon)
73 : ManagePasswordsBubble(webContents, displayReason), 77 : ManagePasswordsBubble(webContents, displayReason),
74 icon_(icon), 78 icon_(icon),
75 closing_(false), 79 closing_(false),
76 controller_(nil), 80 controller_(nil),
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
127 131
128 // static 132 // static
129 void ManagePasswordsBubbleCocoa::ShowBubble(content::WebContents* webContents, 133 void ManagePasswordsBubbleCocoa::ShowBubble(content::WebContents* webContents,
130 DisplayReason displayReason, 134 DisplayReason displayReason,
131 ManagePasswordsIcon* icon) { 135 ManagePasswordsIcon* icon) {
132 if (bubble_) 136 if (bubble_)
133 return; 137 return;
134 bubble_ = new ManagePasswordsBubbleCocoa(webContents, displayReason, icon); 138 bubble_ = new ManagePasswordsBubbleCocoa(webContents, displayReason, icon);
135 bubble_->Show(); 139 bubble_->Show();
136 } 140 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/browser_dialogs.h ('k') | chrome/browser/ui/passwords/manage_passwords_ui_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698