Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1051)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ui/views/widget/root_view_unittest.cc

Issue 565583005: Clean up GestureEventDetails constructors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Alwasy set oldest_touch_id_ to -1 in the constructor Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ui/events/gesture_event_details.cc ('K') | « ui/views/view_targeter_unittest.cc ('k') | ui/views/widget/widget_interactive_uitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/widget/root_view_unittest.cc
diff --git a/ui/views/widget/root_view_unittest.cc b/ui/views/widget/root_view_unittest.cc
index d13e6c99c5cb7ad3bdcb9f91098993df03c9cf05..f4836cd7e095d87ee30f8121efbfb755d55d9e9a 100644
--- a/ui/views/widget/root_view_unittest.cc
+++ b/ui/views/widget/root_view_unittest.cc
@@ -206,14 +206,11 @@ TEST_F(RootViewTest, ContextMenuFromLongPress) {
5,
0,
base::TimeDelta(),
- ui::GestureEventDetails(ui::ET_GESTURE_LONG_PRESS, 0, 0));
+ ui::GestureEventDetails(ui::ET_GESTURE_LONG_PRESS));
ui::EventDispatchDetails details = root_view->OnEventFromSource(&long_press1);
- ui::GestureEvent end1(5,
- 5,
- 0,
- base::TimeDelta(),
- ui::GestureEventDetails(ui::ET_GESTURE_END, 0, 0));
+ ui::GestureEvent end1(
+ 5, 5, 0, base::TimeDelta(), ui::GestureEventDetails(ui::ET_GESTURE_END));
details = root_view->OnEventFromSource(&end1);
EXPECT_FALSE(details.target_destroyed);
@@ -228,14 +225,11 @@ TEST_F(RootViewTest, ContextMenuFromLongPress) {
5,
0,
base::TimeDelta(),
- ui::GestureEventDetails(ui::ET_GESTURE_LONG_PRESS, 0, 0));
+ ui::GestureEventDetails(ui::ET_GESTURE_LONG_PRESS));
details = root_view->OnEventFromSource(&long_press2);
- ui::GestureEvent end2(25,
- 5,
- 0,
- base::TimeDelta(),
- ui::GestureEventDetails(ui::ET_GESTURE_END, 0, 0));
+ ui::GestureEvent end2(
+ 25, 5, 0, base::TimeDelta(), ui::GestureEventDetails(ui::ET_GESTURE_END));
details = root_view->OnEventFromSource(&end2);
EXPECT_FALSE(details.target_destroyed);
@@ -250,14 +244,11 @@ TEST_F(RootViewTest, ContextMenuFromLongPress) {
50,
0,
base::TimeDelta(),
- ui::GestureEventDetails(ui::ET_GESTURE_LONG_PRESS, 0, 0));
+ ui::GestureEventDetails(ui::ET_GESTURE_LONG_PRESS));
details = root_view->OnEventFromSource(&long_press3);
- ui::GestureEvent end3(25,
- 5,
- 0,
- base::TimeDelta(),
- ui::GestureEventDetails(ui::ET_GESTURE_END, 0, 0));
+ ui::GestureEvent end3(
+ 25, 5, 0, base::TimeDelta(), ui::GestureEventDetails(ui::ET_GESTURE_END));
details = root_view->OnEventFromSource(&end3);
EXPECT_FALSE(details.target_destroyed);
@@ -300,14 +291,11 @@ TEST_F(RootViewTest, ContextMenuFromLongPressOnDisabledView) {
5,
0,
base::TimeDelta(),
- ui::GestureEventDetails(ui::ET_GESTURE_LONG_PRESS, 0, 0));
+ ui::GestureEventDetails(ui::ET_GESTURE_LONG_PRESS));
ui::EventDispatchDetails details = root_view->OnEventFromSource(&long_press1);
- ui::GestureEvent end1(5,
- 5,
- 0,
- base::TimeDelta(),
- ui::GestureEventDetails(ui::ET_GESTURE_END, 0, 0));
+ ui::GestureEvent end1(
+ 5, 5, 0, base::TimeDelta(), ui::GestureEventDetails(ui::ET_GESTURE_END));
details = root_view->OnEventFromSource(&end1);
EXPECT_FALSE(details.target_destroyed);
@@ -322,14 +310,11 @@ TEST_F(RootViewTest, ContextMenuFromLongPressOnDisabledView) {
5,
0,
base::TimeDelta(),
- ui::GestureEventDetails(ui::ET_GESTURE_LONG_PRESS, 0, 0));
+ ui::GestureEventDetails(ui::ET_GESTURE_LONG_PRESS));
details = root_view->OnEventFromSource(&long_press2);
- ui::GestureEvent end2(25,
- 5,
- 0,
- base::TimeDelta(),
- ui::GestureEventDetails(ui::ET_GESTURE_END, 0, 0));
+ ui::GestureEvent end2(
+ 25, 5, 0, base::TimeDelta(), ui::GestureEventDetails(ui::ET_GESTURE_END));
details = root_view->OnEventFromSource(&end2);
EXPECT_FALSE(details.target_destroyed);
@@ -344,14 +329,11 @@ TEST_F(RootViewTest, ContextMenuFromLongPressOnDisabledView) {
50,
0,
base::TimeDelta(),
- ui::GestureEventDetails(ui::ET_GESTURE_LONG_PRESS, 0, 0));
+ ui::GestureEventDetails(ui::ET_GESTURE_LONG_PRESS));
details = root_view->OnEventFromSource(&long_press3);
- ui::GestureEvent end3(25,
- 5,
- 0,
- base::TimeDelta(),
- ui::GestureEventDetails(ui::ET_GESTURE_END, 0, 0));
+ ui::GestureEvent end3(
+ 25, 5, 0, base::TimeDelta(), ui::GestureEventDetails(ui::ET_GESTURE_END));
details = root_view->OnEventFromSource(&end3);
EXPECT_FALSE(details.target_destroyed);
« ui/events/gesture_event_details.cc ('K') | « ui/views/view_targeter_unittest.cc ('k') | ui/views/widget/widget_interactive_uitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698