Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: ui/views/view_targeter_unittest.cc

Issue 565583005: Clean up GestureEventDetails constructors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/view_targeter_unittest.cc
diff --git a/ui/views/view_targeter_unittest.cc b/ui/views/view_targeter_unittest.cc
index c860c6721145d959ed1f7c70904b43b3e1fe1bf3..0229fe8fd1b027c0a353963a3e8bb1d33e05ec01 100644
--- a/ui/views/view_targeter_unittest.cc
+++ b/ui/views/view_targeter_unittest.cc
@@ -231,7 +231,7 @@ class GestureEventForTest : public ui::GestureEvent {
y,
0,
base::TimeDelta(),
- ui::GestureEventDetails(type, 0.0f, 0.0f)) {}
+ ui::GestureEventDetails(type)) {}
GestureEventForTest(ui::GestureEventDetails details, int x, int y)
: GestureEvent(x, y, 0, base::TimeDelta(), details) {}
@@ -266,13 +266,13 @@ TEST_F(ViewTargeterTest, ViewTargeterForGestureEvents) {
// Define some gesture events for testing.
gfx::Rect bounding_box(gfx::Point(46, 46), gfx::Size(8, 8));
gfx::Point center_point(bounding_box.CenterPoint());
- ui::GestureEventDetails details(ui::ET_GESTURE_TAP, 0.0f, 0.0f);
+ ui::GestureEventDetails details(ui::ET_GESTURE_TAP);
details.set_bounding_box(bounding_box);
GestureEventForTest tap(details, center_point.x(), center_point.y());
- details = ui::GestureEventDetails(ui::ET_GESTURE_SCROLL_BEGIN, 0.0f, 0.0f);
+ details = ui::GestureEventDetails(ui::ET_GESTURE_SCROLL_BEGIN);
details.set_bounding_box(bounding_box);
GestureEventForTest scroll_begin(details, center_point.x(), center_point.y());
- details = ui::GestureEventDetails(ui::ET_GESTURE_END, 0.0f, 0.0f);
+ details = ui::GestureEventDetails(ui::ET_GESTURE_END);
details.set_bounding_box(bounding_box);
GestureEventForTest end(details, center_point.x(), center_point.y());
@@ -324,14 +324,14 @@ TEST_F(ViewTargeterTest, ViewTargeterForGestureEvents) {
// again (calls to FindTargetForEvent() and FindNextBestTarget()
// mutate the location of the gesture events to be in the coordinate
// space of the returned view).
- details = ui::GestureEventDetails(ui::ET_GESTURE_TAP, 0.0f, 0.0f);
+ details = ui::GestureEventDetails(ui::ET_GESTURE_TAP);
details.set_bounding_box(bounding_box);
tap = GestureEventForTest(details, center_point.x(), center_point.y());
- details = ui::GestureEventDetails(ui::ET_GESTURE_SCROLL_BEGIN, 0.0f, 0.0f);
+ details = ui::GestureEventDetails(ui::ET_GESTURE_SCROLL_BEGIN);
details.set_bounding_box(bounding_box);
scroll_begin =
GestureEventForTest(details, center_point.x(), center_point.y());
- details = ui::GestureEventDetails(ui::ET_GESTURE_END, 0.0f, 0.0f);
+ details = ui::GestureEventDetails(ui::ET_GESTURE_END);
details.set_bounding_box(bounding_box);
end = GestureEventForTest(details, center_point.x(), center_point.y());
@@ -381,7 +381,7 @@ TEST_F(ViewTargeterTest, GestureEventCoordinateConversion) {
// in root view coordinates with width and height of 4.
gfx::Rect bounding_box(gfx::Point(58, 58), gfx::Size(4, 4));
gfx::Point center_point(bounding_box.CenterPoint());
- ui::GestureEventDetails details(ui::ET_GESTURE_TAP, 0.0f, 0.0f);
+ ui::GestureEventDetails details(ui::ET_GESTURE_TAP);
details.set_bounding_box(bounding_box);
GestureEventForTest tap(details, center_point.x(), center_point.y());

Powered by Google App Engine
This is Rietveld 408576698