content/browser/web_contents/touch_editable_impl_aura_browsertest.cc - Issue 565583005: Clean up GestureEventDetails constructors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/touch_editable_impl_aura_browsertest.cc

Issue 565583005: Clean up GestureEventDetails constructors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/input/gesture_text_selector_unittest.cc ('k') | ui/aura/remote_window_tree_host_win.cc » ('j') | ui/events/gesture_event_details.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/touch_editable_impl_aura_browsertest.cc

diff --git a/content/browser/web_contents/touch_editable_impl_aura_browsertest.cc b/content/browser/web_contents/touch_editable_impl_aura_browsertest.cc

index 421f4ba2dd7a2a97c54e5708afcd743d87916677..72c6cec1dfcb27902e744fb46fc9ae9539b5c86e 100644

--- a/content/browser/web_contents/touch_editable_impl_aura_browsertest.cc

+++ b/content/browser/web_contents/touch_editable_impl_aura_browsertest.cc

@@ -207,7 +207,7 @@ IN_PROC_BROWSER_TEST_F(TouchEditableImplAuraTest,

10,

ui::EventTimeForNow(),

- ui::GestureEventDetails(ui::ET_GESTURE_LONG_PRESS, 0, 0));

+ ui::GestureEventDetails(ui::ET_GESTURE_LONG_PRESS));

touch_editable->Reset();

rwhva->OnGestureEvent(&long_press);

touch_editable->WaitForSelectionChangeCallback();

@@ -227,7 +227,7 @@ IN_PROC_BROWSER_TEST_F(TouchEditableImplAuraTest,

10,

ui::EventTimeForNow(),

- ui::GestureEventDetails(ui::ET_GESTURE_SCROLL_BEGIN, 0, 0));

+ ui::GestureEventDetails(ui::ET_GESTURE_SCROLL_BEGIN));

rwhva->OnGestureEvent(&scroll_begin);

EXPECT_FALSE(GetTouchSelectionController(touch_editable));

@@ -237,7 +237,7 @@ IN_PROC_BROWSER_TEST_F(TouchEditableImplAuraTest,

10,

ui::EventTimeForNow(),

- ui::GestureEventDetails(ui::ET_GESTURE_SCROLL_END, 0, 0));

+ ui::GestureEventDetails(ui::ET_GESTURE_SCROLL_END));

rwhva->OnGestureEvent(&scroll_end);

EXPECT_TRUE(GetTouchSelectionController(touch_editable));

}

@@ -262,7 +262,7 @@ IN_PROC_BROWSER_TEST_F(TouchEditableImplAuraTest,

10,

ui::EventTimeForNow(),

- ui::GestureEventDetails(ui::ET_GESTURE_LONG_PRESS, 0, 0));

+ ui::GestureEventDetails(ui::ET_GESTURE_LONG_PRESS));

touch_editable->Reset();

rwhva->OnGestureEvent(&long_press);

touch_editable->WaitForSelectionChangeCallback();

@@ -292,12 +292,9 @@ IN_PROC_BROWSER_TEST_F(TouchEditableImplAuraTest,

EXPECT_EQ(GetRenderWidgetHostViewAura(touch_editable), rwhva);

// Double-tap to select word.

- ui::GestureEvent double_tap(

- 10,

- 0,

- ui::EventTimeForNow(),

- ui::GestureEventDetails(ui::ET_GESTURE_TAP, 2, 0));

+ ui::GestureEventDetails details(ui::ET_GESTURE_TAP);

+ details.set_tap_count(2);

+ ui::GestureEvent double_tap(10, 10, 0, ui::EventTimeForNow(), details);

touch_editable->Reset();

rwhva->OnGestureEvent(&double_tap);

touch_editable->WaitForSelectionChangeCallback();