chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc - Issue 565583005: Clean up GestureEventDetails constructors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc

Issue 565583005: Clean up GestureEventDetails constructors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/desktop_media_picker_views_unittest.cc ('k') | content/browser/renderer_host/input/gesture_text_selector_unittest.cc » ('j') | ui/events/gesture_event_details.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc

diff --git a/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc b/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc

index 4b6b5e8d7ba65cc8fe62d0bf8aa5903065543a70..9ac23b45a6edcdfdda2a8880e3d47259d925ab0e 100644

--- a/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc

+++ b/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc

@@ -335,17 +335,16 @@ IN_PROC_BROWSER_TEST_F(TabDragControllerTest, GestureEndShouldEndDragTest) {

tab_1_center.x(),

base::TimeDelta(),

- ui::GestureEventDetails(ui::ET_GESTURE_TAP_DOWN, 0.0f, 0.0f));

+ ui::GestureEventDetails(ui::ET_GESTURE_TAP_DOWN));

tab_strip->MaybeStartDrag(tab1, gesture_tap_down,

tab_strip->GetSelectionModel());

EXPECT_TRUE(TabDragController::IsActive());

- ui::GestureEvent gesture_end(

- tab_1_center.x(),

- 0,

- base::TimeDelta(),

- ui::GestureEventDetails(ui::ET_GESTURE_END, 0.0f, 0.0f));

+ ui::GestureEvent gesture_end(tab_1_center.x(),

+ tab_1_center.x(),

+ 0,

+ base::TimeDelta(),

+ ui::GestureEventDetails(ui::ET_GESTURE_END));

tab_strip->OnGestureEvent(&gesture_end);

EXPECT_FALSE(TabDragController::IsActive());

EXPECT_FALSE(tab_strip->IsDragSessionActive());