Add scoped path overrides for system directories for ExtensionBrowserTests.

chrome/browser/extensions/extension_browsertest.h

Index: chrome/browser/extensions/extension_browsertest.h
diff --git a/chrome/browser/extensions/extension_browsertest.h b/chrome/browser/extensions/extension_browsertest.h
index 7cd69f676217ad9ba5fc5ac2f4fa6c3e59ccdb13..a759cae8ff595a8d81475ee9ddb493bc7166eabc 100644
--- a/chrome/browser/extensions/extension_browsertest.h
+++ b/chrome/browser/extensions/extension_browsertest.h
@@ -11,6 +11,7 @@
 
 #include "base/files/file_path.h"
 #include "base/files/scoped_temp_dir.h"
+#include "base/test/scoped_path_override.h"
 #include "chrome/browser/extensions/extension_test_notification_observer.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
@@ -375,6 +376,18 @@ class ExtensionBrowserTest : virtual public InProcessBrowserTest {
   extensions::FeatureSwitch::ScopedOverride
       override_prompt_for_external_extensions_;
 
+  base::ScopedTempDir fake_user_desktop_;
+  base::ScopedTempDir fake_common_desktop_;
+  base::ScopedTempDir fake_user_quick_launch_;
+  base::ScopedTempDir fake_default_user_quick_launch_;
+  base::ScopedTempDir fake_start_menu_;
+  base::ScopedTempDir fake_common_start_menu_;
+  scoped_ptr<base::ScopedPathOverride> user_desktop_override_;
+  scoped_ptr<base::ScopedPathOverride> common_desktop_override_;
+  scoped_ptr<base::ScopedPathOverride> user_quick_launch_override_;
+  scoped_ptr<base::ScopedPathOverride> start_menu_override_;
+  scoped_ptr<base::ScopedPathOverride> common_start_menu_override_;

[gab, 2014/09/12 13:57:09]

Add a comment explaining why we're mocking those paths.

[gab, 2014/09/12 13:57:09]

Since the tests don't need to reference the paths directly, simply use direct 

base::ScopedPathOverride foo_override_;

members (which will internally use their own ScopedTempDir).

[calamity, 2014/09/15 01:50:28]

Done.

[calamity, 2014/09/15 01:50:28]

Done.

+
   // The default profile to be used.
   Profile* profile_;