Add scoped path overrides for system directories for ExtensionBrowserTests.

Add scoped path overrides for system directories for ExtensionBrowserTests.

This CL adds path overrides for shortcut directories in testing environments.
This will ensure tests don't pollute the build bots with shortcuts

BUG=411970
Committed: https://crrev.com/6c0732b86d853652de1a2759bf76b39d4cc916a0
Cr-Commit-Position: refs/heads/master@{#295012}

[calamity, 2014-09-12 06:56:30]

Patchset #1 (id:1) has been deleted

[calamity, 2014-09-12 06:56:35]

Patchset #2 (id:40001) has been deleted

[calamity, 2014-09-12 06:56:41]

Patchset #1 (id:20001) has been deleted

[gab, 2014-09-12 13:57:09]

gab@chromium.org changed reviewers:
+ gab@chromium.org

[gab, 2014-09-12 13:57:09]

https://codereview.chromium.org/565523003/diff/60001/chrome/browser/extension...
File chrome/browser/extensions/extension_browsertest.h (right):

https://codereview.chromium.org/565523003/diff/60001/chrome/browser/extension...
chrome/browser/extensions/extension_browsertest.h:389:
scoped_ptr<base::ScopedPathOverride> common_start_menu_override_;
Since the tests don't need to reference the paths directly, simply use direct 

base::ScopedPathOverride foo_override_;

members (which will internally use their own ScopedTempDir).

https://codereview.chromium.org/565523003/diff/60001/chrome/browser/extension...
chrome/browser/extensions/extension_browsertest.h:389:
scoped_ptr<base::ScopedPathOverride> common_start_menu_override_;
Add a comment explaining why we're mocking those paths.

[grt (UTC plus 2), 2014-09-12 14:14:31]

Thanks for taking care of this! Please add BUG=411970 to the CL description.

[calamity, 2014-09-15 01:50:27]

calamity@chromium.org changed reviewers:
+ yoz@chromium.org

[calamity, 2014-09-15 01:50:28]

+yoz for c/b/extensions/

https://codereview.chromium.org/565523003/diff/60001/chrome/browser/extension...
File chrome/browser/extensions/extension_browsertest.h (right):

https://codereview.chromium.org/565523003/diff/60001/chrome/browser/extension...
chrome/browser/extensions/extension_browsertest.h:389:
scoped_ptr<base::ScopedPathOverride> common_start_menu_override_;
On 2014/09/12 13:57:09, gab wrote:
> Since the tests don't need to reference the paths directly, simply use direct 
> 
> base::ScopedPathOverride foo_override_;
> 
> members (which will internally use their own ScopedTempDir).

Done.

https://codereview.chromium.org/565523003/diff/60001/chrome/browser/extension...
chrome/browser/extensions/extension_browsertest.h:389:
scoped_ptr<base::ScopedPathOverride> common_start_menu_override_;
On 2014/09/12 13:57:09, gab wrote:
> Add a comment explaining why we're mocking those paths.

Done.

[calamity, 2014-09-15 11:20:35]

Patchset #3 (id:100001) has been deleted

[Yoyo Zhou, 2014-09-15 18:54:55]

LGTM but

https://chromiumcodereview.appspot.com/565523003/diff/80001/chrome/browser/ex...
File chrome/browser/extensions/extension_browsertest.h (right):

https://chromiumcodereview.appspot.com/565523003/diff/80001/chrome/browser/ex...
chrome/browser/extensions/extension_browsertest.h:382: // Use mock shortcut
directories to ensure app shortcuts are cleaned up.
This should probably be in a #if defined(OS_WIN) block (see compile failures on
non-windows).

[gab, 2014-09-16 00:01:10]

https://chromiumcodereview.appspot.com/565523003/diff/80001/chrome/browser/ex...
File chrome/browser/extensions/extension_browsertest.h (right):

https://chromiumcodereview.appspot.com/565523003/diff/80001/chrome/browser/ex...
chrome/browser/extensions/extension_browsertest.h:383:
scoped_ptr<base::ScopedPathOverride> user_desktop_override_;
No need for scoped_ptr, a direct member is sufficient.

[calamity, 2014-09-16 00:56:11]

Patchset #3 (id:120001) has been deleted

[calamity, 2014-09-16 00:56:21]

https://chromiumcodereview.appspot.com/565523003/diff/80001/chrome/browser/ex...
File chrome/browser/extensions/extension_browsertest.h (right):

https://chromiumcodereview.appspot.com/565523003/diff/80001/chrome/browser/ex...
chrome/browser/extensions/extension_browsertest.h:382: // Use mock shortcut
directories to ensure app shortcuts are cleaned up.
On 2014/09/15 18:54:55, Yoyo Zhou wrote:
> This should probably be in a #if defined(OS_WIN) block (see compile failures
on
> non-windows).

Done.

https://chromiumcodereview.appspot.com/565523003/diff/80001/chrome/browser/ex...
chrome/browser/extensions/extension_browsertest.h:383:
scoped_ptr<base::ScopedPathOverride> user_desktop_override_;
On 2014/09/16 00:01:10, gab wrote:
> No need for scoped_ptr, a direct member is sufficient.

Done.

[calamity, 2014-09-16 00:56:32]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2014-09-16 01:11:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/565523003/140001

[gab, 2014-09-16 01:30:49]

lgtm

[commit-bot: I haz the power, 2014-09-16 02:28:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-16 02:28:04]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[calamity, 2014-09-16 04:28:21]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2014-09-16 04:28:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/565523003/140001

[commit-bot: I haz the power, 2014-09-16 05:01:13]

Committed patchset #3 (id:140001) as cad403e0880361f5f8f6baa1bfddc7793f49861c

[commit-bot: I haz the power, 2014-09-16 05:02:22]

Patchset 3 (id:??) landed as
https://crrev.com/6c0732b86d853652de1a2759bf76b39d4cc916a0
Cr-Commit-Position: refs/heads/master@{#295012}