Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: Tools/GardeningServer/ui/ct-bot-failure-card.html

Issue 565523002: [Sheriff-o-matic] Refactor cards and get rid of ct-failure-cards (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix includes. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/GardeningServer/ui/ct-bot-failure-card.html
diff --git a/Tools/GardeningServer/ui/ct-bot-failure-card.html b/Tools/GardeningServer/ui/ct-bot-failure-card.html
index 81c32282f51d65bcbcb4960fe86b7a2786867c45..6f4caab699863b361139e926183aec511856f9cc 100644
--- a/Tools/GardeningServer/ui/ct-bot-failure-card.html
+++ b/Tools/GardeningServer/ui/ct-bot-failure-card.html
@@ -8,9 +8,14 @@ found in the LICENSE file.
<link rel="import" href="ct-commit-list.html">
<link rel="import" href="ct-test-list.html">
-<polymer-element name="ct-bot-failure-card" attributes="group builderList" noscript>
+<polymer-element name="ct-bot-failure-card" attributes="group commitLog" noscript>
<template>
<style>
+ :host {
+ display: flex;
+ flex: 1;
ojan 2014/09/11 01:50:04 flex: 1 is a property of the embedder, not the com
+ }
+
ct-builder-grid {
margin-right: 10px;
width: 250px;
@@ -20,12 +25,34 @@ found in the LICENSE file.
flex: 1;
}
</style>
- <ct-builder-grid builderList="{{ builderList }}"></ct-builder-grid>
+ <ct-builder-grid builderList="{{ _builderList }}"></ct-builder-grid>
<div id="failure">
<ct-test-list tests="{{ group.failures }}" tree="{{ tree }}"></ct-test-list>
<ct-commit-list commitList="{{ group.commitList }}"></ct-commit-list>
</div>
</template>
+ <script>
+ Polymer({
+ group: null,
+ commitLog: null,
+ _builderList: null,
+
+ observe: {
+ group: '_updateCommitList',
+ commitLog: '_updateCommitList',
+ 'group.failures': '_updateBuilderList',
+ },
+
+ _updateCommitList: function() {
+ if (this.group && this.group.commitList && this.commitLog)
+ this.group.commitList.update(this.commitLog);
+ },
+
+ _updateBuilderList: function() {
+ this._builderList = new CTBuilderList(this.group.failures);
+ },
+ });
+ </script>
</polymer-element>

Powered by Google App Engine
This is Rietveld 408576698