[Sheriff-o-matic] Refactor cards and get rid of ct-failure-cards

[Sheriff-o-matic] Refactor cards and get rid of ct-failure-cards

Directly embed the failure cards into the failure stream, and abstract
the button UI out into ct-failure-card-buttons.

NOTRY=true
R=ojan@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181864

[ojan, 2014-09-11 01:50:05]

Yay! Thx for doing this.

https://codereview.chromium.org/565523002/diff/20001/Tools/GardeningServer/ui...
File Tools/GardeningServer/ui/ct-bot-failure-card.html (right):

https://codereview.chromium.org/565523002/diff/20001/Tools/GardeningServer/ui...
Tools/GardeningServer/ui/ct-bot-failure-card.html:16: flex: 1;
flex: 1 is a property of the embedder, not the component itself. Please move up.

https://codereview.chromium.org/565523002/diff/20001/Tools/GardeningServer/ui...
File Tools/GardeningServer/ui/ct-failure-card-buttons.html (right):

https://codereview.chromium.org/565523002/diff/20001/Tools/GardeningServer/ui...
Tools/GardeningServer/ui/ct-failure-card-buttons.html:49: <paper-button
id="examine" on-tap="{{ examine }}" label="Examine"></paper-button>
INdentation

https://codereview.chromium.org/565523002/diff/20001/Tools/GardeningServer/ui...
File Tools/GardeningServer/ui/ct-failure-stream.html (right):

https://codereview.chromium.org/565523002/diff/20001/Tools/GardeningServer/ui...
Tools/GardeningServer/ui/ct-failure-stream.html:26:
:host>div:first-of-type::before {
Spaced around the >

https://codereview.chromium.org/565523002/diff/20001/Tools/GardeningServer/ui...
Tools/GardeningServer/ui/ct-failure-stream.html:45: <ct-bot-failure-card
class='{{ { snoozed: group.isSnoozed } | tokenList }}' group="{{ group.data }}"
commitLog="{{ commitLog }}" builderList="{{ _builderList
}}"></ct-bot-failure-card>
You moved the builder list down into the widget but didn't remove it here. But,
actually, I think the builder list should just be a property on group.data. As a
side benefit, that would also fix a bug where we don't update the builder list
properly when just the builder list changes and nothing else in the failure
group does.

[leviw_travelin_and_unemployed, 2014-09-11 19:11:15]

ptal

[ojan, 2014-09-12 00:23:21]

The CQ bit was checked by ojan@chromium.org

[ojan, 2014-09-12 00:23:22]

lgtm

This patch is so great.

[commit-bot: I haz the power, 2014-09-12 00:24:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/565523002/60001

[commit-bot: I haz the power, 2014-09-12 00:24:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-12 00:24:22]

Failed to apply patch for Tools/GardeningServer/model/ct-failures.html:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Tools/GardeningServer/model/ct-failures.html
  Hunk #1 FAILED at 6.
  1 out of 1 hunk FAILED -- saving rejects to file
Tools/GardeningServer/model/ct-failures.html.rej

Patch:       Tools/GardeningServer/model/ct-failures.html
Index: Tools/GardeningServer/model/ct-failures.html
diff --git a/Tools/GardeningServer/model/ct-failures.html
b/Tools/GardeningServer/model/ct-failures.html
index
03be103111c8e1e746c4d7ae8f60ca5d4496e8e7..35f3648d9e042e980c10d28c09aae3122eb1f189
100644
--- a/Tools/GardeningServer/model/ct-failures.html
+++ b/Tools/GardeningServer/model/ct-failures.html
@@ -6,7 +6,6 @@ found in the LICENSE file.
 
 <link rel="import" href="../lib/net.html">
 <link rel="import" href="../lib/update-util.html">
-<link rel="import" href="ct-builder-revisions.html">
 <link rel="import" href="ct-failure.html">
 <link rel="import" href="ct-failure-group.html">
 <link rel="import" href="ct-builder-failure-group-data.html">

[leviw_travelin_and_unemployed, 2014-09-12 00:50:15]

The CQ bit was checked by leviw@chromium.org

[commit-bot: I haz the power, 2014-09-12 00:50:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/565523002/80001

[commit-bot: I haz the power, 2014-09-12 00:51:47]

Committed patchset #5 (id:80001) as 181864