Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 565453002: Add symbolic_constants_posix and its test (Closed)

Created:
6 years, 3 months ago by Mark Mentovai
Modified:
6 years, 3 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

Add symbolic_constants_posix and its test. This includes the functions SignalToString() and StringToSignal(). TEST=util_test SymbolicConstantsPOSIX.* R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/a01c87059b37117f6e2a8060fea964ee493be9eb

Patch Set 1 #

Patch Set 2 : Fix formatting #

Total comments: 4

Patch Set 3 : Address review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+603 lines, -0 lines) Patch
A util/misc/symbolic_constants_common.h View 1 2 1 chunk +132 lines, -0 lines 0 comments Download
A util/posix/symbolic_constants_posix.h View 1 chunk +48 lines, -0 lines 0 comments Download
A util/posix/symbolic_constants_posix.cc View 1 2 1 chunk +166 lines, -0 lines 0 comments Download
A util/posix/symbolic_constants_posix_test.cc View 1 1 chunk +253 lines, -0 lines 0 comments Download
M util/util.gyp View 3 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mark Mentovai
6 years, 3 months ago (2014-09-10 19:35:08 UTC) #2
Robert Sesek
https://codereview.chromium.org/565453002/diff/20001/util/misc/symbolic_constants_common.h File util/misc/symbolic_constants_common.h (right): https://codereview.chromium.org/565453002/diff/20001/util/misc/symbolic_constants_common.h#newcode20 util/misc/symbolic_constants_common.h:20: // Symbolic constant terminology: Can this comment be added ...
6 years, 3 months ago (2014-09-10 20:01:04 UTC) #3
Mark Mentovai
Updated. https://codereview.chromium.org/565453002/diff/20001/util/posix/symbolic_constants_posix.cc File util/posix/symbolic_constants_posix.cc (right): https://codereview.chromium.org/565453002/diff/20001/util/posix/symbolic_constants_posix.cc#newcode17 util/posix/symbolic_constants_posix.cc:17: #include <sys/signal.h> rsesek wrote: > Just for NSIG? ...
6 years, 3 months ago (2014-09-10 20:30:53 UTC) #5
Robert Sesek
LGTM
6 years, 3 months ago (2014-09-10 21:06:51 UTC) #6
Mark Mentovai
6 years, 3 months ago (2014-09-10 21:30:24 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:60001) manually as a01c870 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698