Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 565443002: remove lambda expression in quic (Closed)

Created:
6 years, 3 months ago by Mostyn Bramley-Moore
Modified:
6 years, 3 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

remove lambda expression in quic Followup to CL 478153003 which added a lambda expression even though we haven't officially switched to c++11 yet. Committed: https://crrev.com/b90815544b10850c6021db5ca8d6ec8bb0785068 Cr-Commit-Position: refs/heads/master@{#294269}

Patch Set 1 #

Patch Set 2 : add missing const to keep the android toolchain happy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -4 lines) Patch
M net/quic/quic_received_packet_manager.cc View 1 3 chunks +18 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
Mostyn Bramley-Moore
@Ryan: this seems to build on my machine, and the Quic*.* unit tests run. Three ...
6 years, 3 months ago (2014-09-10 19:01:37 UTC) #2
Mostyn Bramley-Moore
Hmm, the android build failure is legit. Looking into it.
6 years, 3 months ago (2014-09-10 20:59:32 UTC) #3
Ryan Hamilton
ianswett: Can you take a look at this CL? Looks like we accidentally landed some ...
6 years, 3 months ago (2014-09-10 21:00:42 UTC) #5
Ian Swett
lgtm
6 years, 3 months ago (2014-09-10 21:13:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/565443002/20001
6 years, 3 months ago (2014-09-10 21:15:38 UTC) #8
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 3 months ago (2014-09-10 21:15:40 UTC) #10
Ryan Hamilton
lgtm ian, can you make this change in the internal copy of the code?
6 years, 3 months ago (2014-09-10 21:23:52 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/565443002/20001
6 years, 3 months ago (2014-09-10 21:27:25 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001) as e4fac77fe98541a550684a09d214664aa31d2eb1
6 years, 3 months ago (2014-09-11 00:17:02 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 00:23:02 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b90815544b10850c6021db5ca8d6ec8bb0785068
Cr-Commit-Position: refs/heads/master@{#294269}

Powered by Google App Engine
This is Rietveld 408576698