extensions/common/manifest_handlers/externally_connectable_unittest.cc - Issue 565423003: Move extensions manifest tests to run in extensions_unittests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/manifest_handlers/externally_connectable_unittest.cc

Issue 565423003: Move extensions manifest tests to run in extensions_unittests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/api/_manifest_features.json ('K') | « extensions/common/common_manifest_handlers.cc ('k') | extensions/common/manifest_handlers/file_handler_manifest_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/manifest_handlers/externally_connectable_unittest.cc

diff --git a/extensions/common/manifest_handlers/externally_connectable_unittest.cc b/extensions/common/manifest_handlers/externally_connectable_unittest.cc

index 87e29cc66779925c177f16c9dfe3c58014b823dd..7064869c3ab36425d4ee96d43a9a7fdf0a98a6a2 100644

--- a/extensions/common/manifest_handlers/externally_connectable_unittest.cc

+++ b/extensions/common/manifest_handlers/externally_connectable_unittest.cc

@@ -4,10 +4,10 @@

#include <algorithm>

-#include "chrome/common/extensions/manifest_tests/chrome_manifest_test.h"

#include "extensions/common/error_utils.h"

#include "extensions/common/manifest_constants.h"

#include "extensions/common/manifest_handlers/externally_connectable.h"

+#include "extensions/common/manifest_test.h"

#include "extensions/common/permissions/permissions_data.h"

#include "testing/gmock/include/gmock/gmock.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -18,8 +18,7 @@ namespace extensions {

namespace errors = externally_connectable_errors;

-// TODO(jamescook): Convert from ChromeManifestTest to ManifestTest.

-class ExternallyConnectableTest : public ChromeManifestTest {

+class ExternallyConnectableTest : public ManifestTest {

public:

ExternallyConnectableTest() {}

virtual ~ExternallyConnectableTest() {}