chrome/common/extensions/permissions/chrome_api_permissions.cc - Issue 565423003: Move extensions manifest tests to run in extensions_unittests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/permissions/chrome_api_permissions.cc

Issue 565423003: Move extensions manifest tests to run in extensions_unittests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/api/_manifest_features.json ('K') | « chrome/common/extensions/chrome_manifest_handlers.cc ('k') | chrome/test/data/extensions/manifest_tests/externally_connectable_all_ids.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/permissions/chrome_api_permissions.cc

diff --git a/chrome/common/extensions/permissions/chrome_api_permissions.cc b/chrome/common/extensions/permissions/chrome_api_permissions.cc

index e4c6ccbf8b16a15173757a88d540f7e3822e8353..14c557806aa7cc3a2bc86fc3f803533e8621c616 100644

--- a/chrome/common/extensions/permissions/chrome_api_permissions.cc

+++ b/chrome/common/extensions/permissions/chrome_api_permissions.cc

@@ -63,14 +63,6 @@ std::vector<APIPermissionInfo*> ChromeAPIPermissions::GetAllPermissions()

APIPermissionInfo::kFlagCannotBeOptional},

{APIPermission::kEmbeddedExtensionOptions, "embeddedExtensionOptions",

APIPermissionInfo::kFlagCannotBeOptional},

- // NOTE(kalman): this is provided by a manifest property but needs to

- // appear in the install permission dialogue, so we need a fake

- // permission for it. See http://crbug.com/247857.

- {APIPermission::kWebConnectable, "webConnectable",

- APIPermissionInfo::kFlagCannotBeOptional |

- APIPermissionInfo::kFlagInternal,

- IDS_EXTENSION_PROMPT_WARNING_WEB_CONNECTABLE,

- PermissionMessage::kWebConnectable},

{APIPermission::kGeolocation, "geolocation",

APIPermissionInfo::kFlagCannotBeOptional,

IDS_EXTENSION_PROMPT_WARNING_GEOLOCATION,