Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Issue 565393002: Add win8_chromium_rel to the default set of try jobs. (Closed)

Created:
6 years, 3 months ago by danakj
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add win8_chromium_rel to the default set of try jobs. Since the CQ runs this bot, git cl try should too. BUG=413904 Committed: https://crrev.com/c89745a83ee77fb7ef2e939e664cf90f859bef8f Cr-Commit-Position: refs/heads/master@{#294964}

Patch Set 1 : try: #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M PRESUBMIT.py View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (7 generated)
danakj
6 years, 3 months ago (2014-09-12 21:28:40 UTC) #1
danakj
I don't think this CL is working as is, trying to grok the GetPreferredTryMasters method ...
6 years, 3 months ago (2014-09-12 21:32:12 UTC) #2
danakj
There we go, last patchset did it.
6 years, 3 months ago (2014-09-12 21:33:42 UTC) #4
M-A Ruel
I don't manage the TS anymore, so one of CQ owners should approve.
6 years, 3 months ago (2014-09-14 00:03:15 UTC) #7
danakj
pawel, sergey: PTAL
6 years, 3 months ago (2014-09-15 18:47:48 UTC) #8
Sergey Berezin
lgtm
6 years, 3 months ago (2014-09-15 20:37:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/565393002/40001
6 years, 3 months ago (2014-09-15 20:40:41 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/11070)
6 years, 3 months ago (2014-09-15 20:51:35 UTC) #13
danakj
jochen@chromium.org,phajdan.jr@chromium.org: OWNERS review please
6 years, 3 months ago (2014-09-15 23:44:12 UTC) #15
Paweł Hajdan Jr.
LGTM
6 years, 3 months ago (2014-09-16 00:28:37 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/565393002/40001
6 years, 3 months ago (2014-09-16 01:11:19 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:40001) as eddca4968e1d75f080c3ad8ee44fed1ae49f3a06
6 years, 3 months ago (2014-09-16 01:34:05 UTC) #19
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 01:36:58 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c89745a83ee77fb7ef2e939e664cf90f859bef8f
Cr-Commit-Position: refs/heads/master@{#294964}

Powered by Google App Engine
This is Rietveld 408576698