Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Unified Diff: components/component_updater/component_updater_configurator.h

Issue 565363002: Implement support for fallback update check urls in the component updater (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/component_updater/component_updater_configurator.h
diff --git a/components/component_updater/component_updater_configurator.h b/components/component_updater/component_updater_configurator.h
index 4825b5f66ee43dc482c1c6d43afbcea4348ebd8b..6ca4f3c5d858f7a5c2e20bdd084089b51a9fb900 100644
--- a/components/component_updater/component_updater_configurator.h
+++ b/components/component_updater/component_updater_configurator.h
@@ -6,6 +6,7 @@
#define COMPONENTS_COMPONENT_UPDATER_COMPONENT_UPDATER_CONFIGURATOR_H_
#include <string>
+#include <vector>
#include "base/memory/ref_counted.h"
#include "base/memory/scoped_ptr.h"
@@ -53,12 +54,13 @@ class Configurator {
// for the same component.
virtual int OnDemandDelay() const = 0;
- // The url that is going to be used update checks over Omaha protocol.
- virtual GURL UpdateUrl() const = 0;
+ // The urls for the update checks. The urls are tried in order, the first one
erikwright (departed) 2014/09/15 18:37:11 nit: urls -> URLs
Sorin Jianu 2014/09/15 22:17:57 Done.
+ // that succeeds wins.
+ virtual std::vector<GURL> UpdateUrl() const = 0;
- // The url where the completion pings are sent. Invalid if and only if
- // pings are disabled.
- virtual GURL PingUrl() const = 0;
+ // The urls for pings. Returns an empty vector if and only if pings are
erikwright (departed) 2014/09/15 18:37:11 ditto
Sorin Jianu 2014/09/15 22:17:56 Done.
+ // disabled. Similarly, these urls have a fall back behavior too.
erikwright (departed) 2014/09/15 18:37:10 ditto
Sorin Jianu 2014/09/15 22:17:57 Done.
+ virtual std::vector<GURL> PingUrl() const = 0;
// Version of the application. Used to compare the component manifests.
virtual base::Version GetBrowserVersion() const = 0;

Powered by Google App Engine
This is Rietveld 408576698