Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 565353003: Animation: Fix bug in timing in compositor (Closed)

Created:
6 years, 3 months ago by samli
Modified:
6 years, 3 months ago
Reviewers:
ajuma
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Animation: Fix bug in timing in compositor An edge case around direction and playback rate is calculating the time incorrectly. In particular, when the playback rate is negative and the direction is set to AlternateReverse, the resulting iteration times calculated are incorrect. This change brings the compositor in line with the Web Animation Spec to calculate the iteration time. Reference for calculations: http://dev.w3.org/fxtf/web-animations/#core-animation-node-calculations BUG=398330 Committed: https://crrev.com/35099b0441b16ba4ed5f3a331f77bd59f6610926 Cr-Commit-Position: refs/heads/master@{#294708}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -29 lines) Patch
M cc/animation/animation.cc View 2 chunks +37 lines, -28 lines 0 comments Download
M cc/animation/animation_unittest.cc View 2 chunks +37 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
samli
PTAL
6 years, 3 months ago (2014-09-12 21:03:29 UTC) #2
ajuma
On 2014/09/12 21:03:29, samli wrote: > PTAL Nice, lgtm.
6 years, 3 months ago (2014-09-12 22:33:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/565353003/1
6 years, 3 months ago (2014-09-12 23:12:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 0b577cdfccffebec7558263344afc43afbe09171
6 years, 3 months ago (2014-09-13 00:51:36 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-13 00:54:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/35099b0441b16ba4ed5f3a331f77bd59f6610926
Cr-Commit-Position: refs/heads/master@{#294708}

Powered by Google App Engine
This is Rietveld 408576698