Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 565353002: Propogate the clip rect for visible_content_rect into surfaces. (Closed)

Created:
6 years, 3 months ago by danakj
Modified:
6 years, 3 months ago
Reviewers:
Ian Vollick, vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org, ernstm
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Propogate the clip rect for visible_content_rect into surfaces. Currently each render surface takes as its clip rect for visible content rects as the clip rect directly clipping its own surface, but drops the clip for visible content rects from outside the surface. This means that the viewport does not clip the visible_content_rect of any layers that aren't in the root surface. Fixed by intersecting this clip for visible content rects with the one from outside the surface. BUG=410625 Committed: https://crrev.com/f6069db89203f0797e4429c47ae268901c69a299 Cr-Commit-Position: refs/heads/master@{#294706}

Patch Set 1 #

Patch Set 2 : viewportsurface: . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -2 lines) Patch
M cc/trees/layer_tree_host_common.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 1 1 chunk +56 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
danakj
6 years, 3 months ago (2014-09-12 21:07:11 UTC) #2
danakj
6 years, 3 months ago (2014-09-12 21:10:49 UTC) #3
danakj
or +vollick in case he's able to get to this
6 years, 3 months ago (2014-09-12 21:57:40 UTC) #5
Ian Vollick
On 2014/09/12 21:57:40, danakj wrote: > or +vollick in case he's able to get to ...
6 years, 3 months ago (2014-09-12 22:08:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/565353002/20001
6 years, 3 months ago (2014-09-12 22:09:35 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 9ecddf9305cf7e52a7edd09dff387dafaa2b18ed
6 years, 3 months ago (2014-09-13 00:48:48 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-13 00:54:41 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f6069db89203f0797e4429c47ae268901c69a299
Cr-Commit-Position: refs/heads/master@{#294706}

Powered by Google App Engine
This is Rietveld 408576698