[NaCl SDK] nacl_io: Plumb through {,f}utime{,s}

native_client_sdk/src/libraries/nacl_io/kernel_proxy.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "nacl_io/kernel_proxy.h"
 
 #include <assert.h>
 #include <errno.h>
 #include <fcntl.h>
 #include <limits.h>
@@ skipping 306 matching lines @@
 
 char* KernelProxy::getwd(char* buf) {
   if (NULL == buf) {
     errno = EFAULT;
     return NULL;
   }
   return getcwd(buf, MAXPATHLEN);
 }
 
 int KernelProxy::chmod(const char* path, mode_t mode) {
-  int fd = KernelProxy::open(path, O_RDONLY, mode);
+  int fd = open(path, O_RDONLY, mode);
   if (-1 == fd)
     return -1;
 
   int result = fchmod(fd, mode);
   close(fd);
   return result;
 }
 
 int KernelProxy::chown(const char* path, uid_t owner, gid_t group) {
   return 0;
 }
 
 int KernelProxy::fchown(int fd, uid_t owner, gid_t group) {
   return 0;
 }
 
 int KernelProxy::lchown(const char* path, uid_t owner, gid_t group) {
   return 0;
 }
 
-int KernelProxy::utime(const char* filename, const struct utimbuf* times) {
-  return 0;
-}
-
 int KernelProxy::mkdir(const char* path, mode_t mode) {
   ScopedFilesystem fs;
   Path rel;
 
   Error error = AcquireFsAndRelPath(path, &fs, &rel);
   if (error) {
     errno = error;
     return -1;
   }
 
@@ skipping 311 matching lines @@
 
   error = handle->node()->VIoctl(request, args);
   if (error) {
     errno = error;
     return -1;
   }
 
   return 0;
 }
 
+int KernelProxy::futimens(int fd, const struct timespec times[2]) {
+  ScopedKernelHandle handle;
+  Error error = AcquireHandle(fd, &handle);
+  if (error) {
+    errno = error;
+    return -1;
+  }
+
+  error = handle->node()->Futimens(times);
+  if (error) {
+    errno = error;
+    return -1;
+  }
+
+  return 0;
+}
+
 off_t KernelProxy::lseek(int fd, off_t offset, int whence) {
   ScopedKernelHandle handle;
   Error error = AcquireHandle(fd, &handle);
   if (error) {
     errno = error;
     return -1;
   }
 
   off_t new_offset;
   error = handle->Seek(offset, whence, &new_offset);
@@ skipping 18 matching lines @@
   error = fs->Unlink(rel);
   if (error) {
     errno = error;
     return -1;
   }
 
   return 0;
 }
 
 int KernelProxy::truncate(const char* path, off_t len) {
-  int fd = KernelProxy::open(path, O_WRONLY, 0);
+  int fd = open(path, O_WRONLY, 0);
   if (-1 == fd)
     return -1;
 
   int result = ftruncate(fd, len);
   close(fd);
   return result;
 }
 
 int KernelProxy::lstat(const char* path, struct stat* buf) {
   return stat(path, buf);
@@ skipping 125 matching lines @@
 
   return 0;
 }
 
 int KernelProxy::readlink(const char* path, char* buf, size_t count) {
   LOG_TRACE("readlink is not implemented.");
   errno = EINVAL;
   return -1;
 }
 
-int KernelProxy::utimes(const char* filename, const struct timeval times[2]) {
-  LOG_TRACE("utimes is not implemented.");
-  errno = EINVAL;
-  return -1;
+int KernelProxy::utimens(const char* path, const struct timespec times[2]) {
+  int fd = open(path, O_RDONLY, 0);
+  if (-1 == fd)
+    return -1;
+
+  int result = futimens(fd, times);

[Sam Clegg, 2014/09/12 21:36:27]

Add explicit KernelProxy:: here to avoid confusion with C global functions with
the same name?  

[binji, 2014/09/12 21:50:07]

We don't do that for open, close, stat, fstat, etc. Maybe we should go through
and do a pass in another CL?

+  close(fd);
+  return result;
 }
 
 // TODO(noelallen): Needs implementation.
 int KernelProxy::link(const char* oldpath, const char* newpath) {
   LOG_TRACE("link is not implemented.");
   errno = EINVAL;
   return -1;
 }
 
 int KernelProxy::symlink(const char* oldpath, const char* newpath) {
@@ skipping 836 matching lines @@
     errno = ENOTSOCK;
     return -1;
   }
 
   return 0;
 }
 
 #endif  // PROVIDES_SOCKET_API
 
 }  // namespace_nacl_io