Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 56533004: Fix flaky brailleDisplayPrivateApi tests and reenable them. (Closed)

Created:
7 years, 1 month ago by Peter Lundblad
Modified:
7 years, 1 month ago
Reviewers:
dmazzoni
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix flaky brailleDisplayPrivateApi tests and reenable them. BUG=314181 R=dmazzoni@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233441

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -6 lines) Patch
M chrome/browser/extensions/api/braille_display_private/braille_display_private_apitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/braille_display_private/key_events/test.js View 3 chunks +10 lines, -4 lines 0 comments Download
M chrome/test/data/extensions/api_test/braille_display_private/write_dots/test.js View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Peter Lundblad
7 years, 1 month ago (2013-11-05 16:06:28 UTC) #1
dmazzoni
lgtm
7 years, 1 month ago (2013-11-05 17:14:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/plundblad@chromium.org/56533004/340001
7 years, 1 month ago (2013-11-05 17:22:11 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 1 month ago (2013-11-05 17:29:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/plundblad@chromium.org/56533004/340001
7 years, 1 month ago (2013-11-05 18:19:05 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=94094
7 years, 1 month ago (2013-11-05 22:39:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/plundblad@chromium.org/56533004/340001
7 years, 1 month ago (2013-11-06 00:11:37 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=94370
7 years, 1 month ago (2013-11-06 04:07:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/plundblad@chromium.org/56533004/340001
7 years, 1 month ago (2013-11-06 23:10:58 UTC) #9
commit-bot: I haz the power
7 years, 1 month ago (2013-11-07 00:49:09 UTC) #10
Message was sent while issue was closed. 
Change committed as 233441

Powered by Google App Engine
This is Rietveld 408576698