Move application:chromium bindings to mojo/application/

Move application:chromium bindings to mojo/application/

We shouldn't have dependencies on chromium types and whatnot in
mojo/public/

Committed: https://crrev.com/fec4238c35b444b48f863826cb0b8e7df3d501c2
Cr-Commit-Position: refs/heads/master@{#294725}

[jamesr, 2014-09-12 18:28:27]

jamesr@chromium.org changed reviewers:
+ viettrungluu@chromium.org

[darin (slow to review), 2014-09-12 18:54:41]

Could do just mojo/application/ like mojo/environment/. Or make that one
also have a chromium suffix.
On Sep 12, 2014 11:28 AM, <jamesr@chromium.org> wrote:

> Reviewers: viettrungluu,
>
> Description:
> Move application:chromium bindings to mojo/application_chromium
>
> We shouldn't have dependencies on chromium types and whatnot in
> mojo/public/
>
> Please review this at https://codereview.chromium.org/565323002/
>
> SVN Base: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+72, -178 lines):
>   A mojo/application_chromium/BUILD.gn
>   A + mojo/application_chromium/application_runner_chromium.h
>   A + mojo/application_chromium/application_runner_chromium.cc
>   M mojo/application_manager/BUILD.gn
>   M mojo/examples/aura_demo/aura_demo.cc
>   M mojo/examples/aura_demo/view_manager_init.cc
>   M mojo/examples/browser/browser.cc
>   M mojo/examples/compositor_app/compositor_app.cc
>   M mojo/examples/demo_launcher/demo_launcher.cc
>   M mojo/examples/embedded_app/embedded_app.cc
>   M mojo/examples/keyboard/keyboard.cc
>   M mojo/examples/media_viewer/media_viewer.cc
>   M mojo/examples/nesting_app/nesting_app.cc
>   M mojo/examples/pepper_container_app/pepper_container_app.cc
>   M mojo/examples/png_viewer/png_viewer.cc
>   M mojo/examples/surfaces_app/BUILD.gn
>   M mojo/examples/surfaces_app/child_app.cc
>   M mojo/examples/surfaces_app/child_gl_app.cc
>   M mojo/examples/surfaces_app/surfaces_app.cc
>   M mojo/examples/window_manager/window_manager.cc
>   M mojo/examples/wm_flow/app/app.cc
>   M mojo/examples/wm_flow/init/init.cc
>   M mojo/examples/wm_flow/wm/wm.cc
>   M mojo/mojo_base.gyp
>   M mojo/public/cpp/application/BUILD.gn
>   D mojo/public/cpp/application/application_runner_chromium.h
>   D mojo/public/cpp/application/lib/application_runner_chromium.cc
>   M mojo/services/html_viewer/DEPS
>   M mojo/services/html_viewer/html_viewer.cc
>   M mojo/services/native_viewport/BUILD.gn
>   M mojo/services/network/BUILD.gn
>   M mojo/services/network/DEPS
>   M mojo/services/network/main.cc
>   M mojo/services/public/cpp/view_manager/BUILD.gn
>   M mojo/services/surfaces/BUILD.gn
>   M mojo/services/surfaces/DEPS
>   M mojo/services/surfaces/surfaces_service_application.cc
>   M mojo/services/view_manager/BUILD.gn
>   M mojo/services/view_manager/DEPS
>   M mojo/services/view_manager/main.cc
>   M mojo/services/window_manager/BUILD.gn
>   M mojo/services/window_manager/DEPS
>   M mojo/services/window_manager/main.cc
>   M mojo/shell/BUILD.gn
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[jamesr, 2014-09-12 19:12:34]

Makes sense, this puts mojo_application_chromium in mojo/application/

[viettrungluu, 2014-09-12 20:09:59]

LGTM

https://codereview.chromium.org/565323002/diff/20001/mojo/application/BUILD.gn
File mojo/application/BUILD.gn (right):

https://codereview.chromium.org/565323002/diff/20001/mojo/application/BUILD.g...
mojo/application/BUILD.gn:18: 
So many

https://codereview.chromium.org/565323002/diff/20001/mojo/application/BUILD.g...
mojo/application/BUILD.gn:19: 
extra blank lines.

https://codereview.chromium.org/565323002/diff/20001/mojo/mojo_base.gyp
File mojo/mojo_base.gyp (right):

https://codereview.chromium.org/565323002/diff/20001/mojo/mojo_base.gyp#newco...
mojo/mojo_base.gyp:476: 'application/application_runner_chromium.cc',
I wonder if we should rename application_runner_chromium.cc to
application_runner.cc (or ..._impl.cc and ..._impl.h), to be consistent with
environment.

(You don't need to do that in this change.)

[jamesr, 2014-09-13 00:53:55]

The CQ bit was checked by jamesr@chromium.org

[commit-bot: I haz the power, 2014-09-13 01:05:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/565323002/40001

[commit-bot: I haz the power, 2014-09-13 02:04:17]

Committed patchset #3 (id:40001) as c97f0c164ec72716af744f34a357d50258a2fe51

[commit-bot: I haz the power, 2014-09-13 02:06:39]

Patchset 3 (id:??) landed as
https://crrev.com/fec4238c35b444b48f863826cb0b8e7df3d501c2
Cr-Commit-Position: refs/heads/master@{#294725}