Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 565313003: Support doing CopyOutputRequests on surfaces. (Closed)

Created:
6 years, 3 months ago by jbauman
Modified:
6 years, 3 months ago
Reviewers:
jamesr
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Support doing CopyOutputRequests on surfaces. If a surface has a copy output request pending, then the aggregator should avoid merging its root pass into its parent pass, and should instead place the copy request on it. BUG=397730 Committed: https://crrev.com/2cd9f8f5c3acf503ade180a5584a2c5c1e1004e1 Cr-Commit-Position: refs/heads/master@{#294957}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -12 lines) Patch
M cc/surfaces/surface.h View 3 chunks +5 lines, -0 lines 0 comments Download
M cc/surfaces/surface.cc View 3 chunks +20 lines, -2 lines 0 comments Download
M cc/surfaces/surface_aggregator.cc View 1 2 chunks +38 lines, -10 lines 0 comments Download
M cc/surfaces/surface_aggregator_test_helpers.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M cc/surfaces/surface_aggregator_unittest.cc View 1 1 chunk +56 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jbauman
6 years, 3 months ago (2014-09-12 20:07:32 UTC) #2
jamesr
lgtm
6 years, 3 months ago (2014-09-15 17:30:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/565313003/20001
6 years, 3 months ago (2014-09-15 23:32:24 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 71b2771306ec03058c61cade1b95ac6167c2ff7a
6 years, 3 months ago (2014-09-16 01:06:41 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 01:09:20 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2cd9f8f5c3acf503ade180a5584a2c5c1e1004e1
Cr-Commit-Position: refs/heads/master@{#294957}

Powered by Google App Engine
This is Rietveld 408576698