Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 565303003: Use correct HRTF elevation response for negative elevations. (Closed)

Created:
6 years, 3 months ago by Raymond Toy
Modified:
6 years, 3 months ago
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Use correct HRTF elevation response for negative elevations. The computed index for negative elevations was off by one. When the elevation is -45 deg, the selected response corresponded to the entry for 90 deg, not 315 deg. To simplify things, we just use a short table to map the index to the (positive) elevation angle. No tests for this, but see crbug.com/411191. BUG=412442 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181986

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -3 lines) Patch
M Source/platform/audio/HRTFElevation.cpp View 2 chunks +23 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Raymond Toy
PTAL.
6 years, 3 months ago (2014-09-12 22:36:16 UTC) #2
Ken Russell (switch to Gerrit)
LGTM Would be good to add a test for this.
6 years, 3 months ago (2014-09-13 19:59:50 UTC) #3
Raymond Toy
On 2014/09/13 19:59:50, Ken Russell wrote: > LGTM > > Would be good to add ...
6 years, 3 months ago (2014-09-15 16:25:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/565303003/1
6 years, 3 months ago (2014-09-15 16:27:24 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 17:27:47 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181986

Powered by Google App Engine
This is Rietveld 408576698