Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 565293003: Revert of Non-plafrom-specific part of an OwnerSettingsService is moved to components/ownership/*. (Closed)

Created:
6 years, 3 months ago by nasko
Modified:
6 years, 3 months ago
CC:
chromium-reviews, davemoore+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Non-plafrom-specific part of an OwnerSettingsService is moved to components/ownership/*. (patchset #4 id:60001 of https://codereview.chromium.org/548323003/) Reason for revert: Breaks compile on multiple bots: http://build.chromium.org/p/chromium.win/builders/Win%20Builder%20%28dbg%29/builds/3134 http://build.chromium.org/p/chromium.mac/builders/Mac%20Builder%20%28dbg%29/builds/73424 http://build.chromium.org/p/chromium.webkit/builders/GPU%20Win%20Builder%20%28dbg%29/builds/13365 Original issue's description: > Non-plafrom-specific part of an OwnerSettingsService is moved to components/ownership/*. > > BUG=398856 > TEST=existing browser_tests and unit_tests > R=erg@chromium.org, jochen@chromium.org, nkostylev@chromium.org, pastarmovj@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/46a58bffbe303d3484d7cc288b47bfae5388109c TBR=jochen@chromium.org,erg@chromium.org,nkostylev@chromium.org,pastarmovj@chromium.org,ygorshenin@chromium.org NOTREECHECKS=true NOTRY=true BUG=398856 Committed: https://crrev.com/1d9925fdc873e99328ba6524d1600da678a9e306 Cr-Commit-Position: refs/heads/master@{#294618}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+923 lines, -985 lines) Patch
M chrome/browser/chromeos/app_mode/kiosk_app_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/auth/chrome_cryptohome_authenticator.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/auth/cryptohome_authenticator_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A chrome/browser/chromeos/ownership/owner_settings_service.h View 1 chunk +154 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/ownership/owner_settings_service.cc View 1 chunk +517 lines, -0 lines 0 comments Download
D chrome/browser/chromeos/ownership/owner_settings_service_chromeos.h View 1 chunk +0 lines, -121 lines 0 comments Download
D chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc View 1 chunk +0 lines, -326 lines 0 comments Download
D chrome/browser/chromeos/ownership/owner_settings_service_chromeos_factory.h View 1 chunk +0 lines, -59 lines 0 comments Download
D chrome/browser/chromeos/ownership/owner_settings_service_chromeos_factory.cc View 1 chunk +0 lines, -76 lines 0 comments Download
A chrome/browser/chromeos/ownership/owner_settings_service_factory.h View 1 chunk +60 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/ownership/owner_settings_service_factory.cc View 1 chunk +73 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_provider_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_service.h View 5 chunks +45 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_service.cc View 5 chunks +13 lines, -101 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_service_unittest.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_test_helper.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/settings/session_manager_operation.h View 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/settings/session_manager_operation.cc View 1 chunk +11 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/settings/session_manager_operation_unittest.cc View 5 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/flags_ui.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +4 lines, -4 lines 0 comments Download
M components/ownership.gypi View 2 chunks +0 lines, -7 lines 0 comments Download
M components/ownership/BUILD.gn View 2 chunks +0 lines, -4 lines 0 comments Download
M components/ownership/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
D components/ownership/owner_settings_service.h View 1 chunk +0 lines, -102 lines 0 comments Download
D components/ownership/owner_settings_service.cc View 1 chunk +0 lines, -118 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nasko
Created Revert of Non-plafrom-specific part of an OwnerSettingsService is moved to components/ownership/*.
6 years, 3 months ago (2014-09-12 17:54:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/565293003/1
6 years, 3 months ago (2014-09-12 18:19:45 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 5fbb9e9f6acea1cb115a1487eeef71997e62e236
6 years, 3 months ago (2014-09-12 18:29:43 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 18:36:04 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1d9925fdc873e99328ba6524d1600da678a9e306
Cr-Commit-Position: refs/heads/master@{#294618}

Powered by Google App Engine
This is Rietveld 408576698