GN: Add notion of 'complete' static libraries, akin to GYP.

tools/gn/ninja_binary_target_writer.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "tools/gn/ninja_binary_target_writer.h"
 
 #include <set>
 
 #include "base/strings/string_util.h"
 #include "tools/gn/config_values_extractors.h"
@@ skipping 375 matching lines @@
   const LabelTargetVector& datadeps = target_->datadeps();
   for (size_t i = 0; i < datadeps.size(); i++)
     non_linkable_deps->push_back(datadeps[i].ptr);
 }
 
 void NinjaBinaryTargetWriter::ClassifyDependency(
     const Target* dep,
     UniqueVector<OutputFile>* extra_object_files,
     UniqueVector<const Target*>* linkable_deps,
     UniqueVector<const Target*>* non_linkable_deps) const {
-  // Only these types of outputs have libraries linked into them. Child deps of
-  // static libraries get pushed up the dependency tree until one of these is
-  // reached, and source sets don't link at all.
-  bool can_link_libs =
-      (target_->output_type() == Target::EXECUTABLE ||
-       target_->output_type() == Target::SHARED_LIBRARY);
+  // Only the following types of outputs have libraries linked into them:
+  //  EXECUTABLE
+  //  SHARED_LIBRARY
+  //  _complete_ STATIC_LIBRARY
+  //
+  // Child deps of intermediate static libraries get pushed up the
+  // dependency tree until one of these is reached, and source sets
+  // don't link at all.
+  bool can_link_libs = target_->IsFinal();
 
   if (dep->output_type() == Target::SOURCE_SET) {
-    // Source sets have their object files linked into final targets (shared
-    // libraries and executables). Intermediate static libraries and other
-    // source sets just forward the dependency, otherwise the files in the
-    // source set can easily get linked more than once which will cause
+    // Source sets have their object files linked into final targets
+    // (shared libraries, executables, and complete static
+    // libraries). Intermediate static libraries and other source sets
+    // just forward the dependency, otherwise the files in the source
+    // set can easily get linked more than once which will cause
     // multiple definition errors.
-    //
-    // In the future, we may need a way to specify a "complete" static library
-    // for cases where you want a static library that includes all source sets
-    // (like if you're shipping that to customers to link against).
-    if (target_->output_type() != Target::SOURCE_SET &&
-        target_->output_type() != Target::STATIC_LIBRARY) {
-      // Linking in a source set to an executable or shared library, copy its
-      // object files.
+    if (can_link_libs) {
+      // Linking in a source set to an executable, shared library, or
+      // complete static library, so copy its object files.
       std::vector<OutputFile> tool_outputs;  // Prevent allocation in loop.
       for (size_t i = 0; i < dep->sources().size(); i++) {
         Toolchain::ToolType tool_type = Toolchain::TYPE_NONE;
         if (GetOutputFilesForSource(dep, dep->sources()[i], &tool_type,
                                     &tool_outputs)) {
           // Only link the first output if there are more than one.
           extra_object_files->push_back(tool_outputs[0]);
         }
       }
     }
@@ skipping 42 matching lines @@
     return false;  // No tool for this file (it's a header file or something).
   const Tool* tool = target->toolchain()->GetTool(*computed_tool_type);
   if (!tool)
     return false;  // Tool does not apply for this toolchain.file.
 
   // Figure out what output(s) this compiler produces.
   SubstitutionWriter::ApplyListToCompilerAsOutputFile(
       target, source, tool->outputs(), outputs);
   return !outputs->empty();
 }