GN: Add notion of 'complete' static libraries, akin to GYP.

tools/gn/binary_target_generator.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "tools/gn/binary_target_generator.h"
 
 #include "tools/gn/config_values_generator.h"
 #include "tools/gn/err.h"
 #include "tools/gn/functions.h"
 #include "tools/gn/scope.h"
@@ skipping 58 matching lines @@
 
 void BinaryTargetGenerator::FillCheckIncludes() {
   const Value* value = scope_->GetValue(variables::kCheckIncludes, true);
   if (!value)
     return;
   if (!value->VerifyTypeIs(Value::BOOLEAN, err_))
     return;
   target_->set_check_includes(value->boolean_value());
 }
 
+void BinaryTargetGenerator::FillCompleteStaticLib() {

[brettw, 2014/09/12 23:05:06]

You forgot to call this function, silly-pants!

[Chris Masone, 2014/09/12 23:15:00]

Done.

+  if (target_->output_type() == Target::STATIC_LIBRARY) {
+    const Value* value = scope_->GetValue(variables::kCompleteStaticLib, true);
+    if (!value)
+      return;
+    if (!value->VerifyTypeIs(Value::BOOLEAN, err_))
+      return;
+    target_->set_complete_static_lib(value->boolean_value());
+  }
+}
+
 void BinaryTargetGenerator::FillOutputName() {
   const Value* value = scope_->GetValue(variables::kOutputName, true);
   if (!value)
     return;
   if (!value->VerifyTypeIs(Value::STRING, err_))
     return;
   target_->set_output_name(value->string_value());
 }
 
 void BinaryTargetGenerator::FillOutputExtension() {
@@ skipping 34 matching lines @@
           "allow_circular_includes_from only allows\ntargets present in the "
           "deps.");
       return;
     }
   }
 
   // Add to the set.
   for (size_t i = 0; i < circular.size(); i++)
     target_->allow_circular_includes_from().insert(circular[i]);
 }