Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 565273002: Move webrequest_api_constants.h/.cc (Closed)

Created:
6 years, 3 months ago by wjmaclean
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, Fady Samuel, Xi Han, lfg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move webrequest_api_constants.h/.cc In preparation for moving webrequest_action, webrequest_rules_registry, we need to move this dependency. BUG=352293 Committed: https://crrev.com/4b2da4cde5e7f5d952a68c5af36a2dad363d6f0e Cr-Commit-Position: refs/heads/master@{#294631}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -180 lines) Patch
M chrome/browser/extensions/api/declarative_webrequest/webrequest_action.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/web_request/upload_data_presenter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/web_request/upload_data_presenter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api.cc View 2 chunks +1 line, -1 line 0 comments Download
D chrome/browser/extensions/api/web_request/web_request_api_constants.h View 1 chunk +0 lines, -88 lines 0 comments Download
D chrome/browser/extensions/api/web_request/web_request_api_constants.cc View 1 chunk +0 lines, -81 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/browser/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A + extensions/browser/api/web_request/web_request_api_constants.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/browser/api/web_request/web_request_api_constants.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/extensions.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
wjmaclean
Simple move, please take a look.
6 years, 3 months ago (2014-09-12 16:59:33 UTC) #2
Ken Rockot(use gerrit already)
lgtm
6 years, 3 months ago (2014-09-12 17:04:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/565273002/1
6 years, 3 months ago (2014-09-12 17:07:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as ecdb6fd05267a987fcc0541b26b89f1c4f7b1f4b
6 years, 3 months ago (2014-09-12 19:26:37 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 19:33:40 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/4b2da4cde5e7f5d952a68c5af36a2dad363d6f0e
Cr-Commit-Position: refs/heads/master@{#294631}

Powered by Google App Engine
This is Rietveld 408576698