Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 565263006: Remove legacy version of the control channel protocol. (Closed)

Created:
6 years, 3 months ago by Sergey Ulanov
Modified:
6 years, 3 months ago
Reviewers:
Wez
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove legacy version of the control channel protocol. All current versions of host and client support capabilities, we no longer need to keep support for older versions. Committed: https://crrev.com/f69b019f961526cbef468814597c9d10d8237bab Cr-Commit-Position: refs/heads/master@{#294752}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -51 lines) Patch
M remoting/client/chromoting_client.cc View 1 chunk +4 lines, -14 lines 0 comments Download
M remoting/host/client_session.cc View 3 chunks +8 lines, -23 lines 0 comments Download
M remoting/protocol/session_config.h View 1 chunk +0 lines, -3 lines 0 comments Download
M remoting/protocol/session_config.cc View 3 chunks +0 lines, -11 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
Sergey Ulanov
6 years, 3 months ago (2014-09-12 23:24:41 UTC) #2
Wez
lgtm https://codereview.chromium.org/565263006/diff/1/remoting/protocol/session_config.cc File remoting/protocol/session_config.cc (left): https://codereview.chromium.org/565263006/diff/1/remoting/protocol/session_config.cc#oldcode12 remoting/protocol/session_config.cc:12: const int kDefaultStreamVersion = 2; nit: Add a ...
6 years, 3 months ago (2014-09-13 17:21:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/565263006/1
6 years, 3 months ago (2014-09-13 17:22:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 943735f0c744da994f734df1b6f18a2631a1258f
6 years, 3 months ago (2014-09-13 20:43:17 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-13 20:51:20 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f69b019f961526cbef468814597c9d10d8237bab
Cr-Commit-Position: refs/heads/master@{#294752}

Powered by Google App Engine
This is Rietveld 408576698