Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2763)

Unified Diff: chrome/browser/prerender/prerender_tab_helper.h

Issue 565263005: Remove the use of ProvisionalChangeToMainFrameUrl from prerender code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@redirsupervised
Patch Set: better Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prerender/prerender_tab_helper.h
diff --git a/chrome/browser/prerender/prerender_tab_helper.h b/chrome/browser/prerender/prerender_tab_helper.h
index 260091dd219f15a2054ce5c2327f5628302fcda8..f0a2d34c88af98f14d8f041cbf7e0085c64c8988 100644
--- a/chrome/browser/prerender/prerender_tab_helper.h
+++ b/chrome/browser/prerender/prerender_tab_helper.h
@@ -51,9 +51,9 @@ class PrerenderTabHelper
virtual ~PrerenderTabHelper();
// content::WebContentsObserver implementation.
- virtual void ProvisionalChangeToMainFrameUrl(
- const GURL& url,
- content::RenderFrameHost* render_frame_host) OVERRIDE;
+ virtual void DidGetRedirectForResourceRequest(
+ content::RenderViewHost* render_view_host,
+ const content::ResourceRedirectDetails& details) OVERRIDE;
virtual void DidStopLoading(
content::RenderViewHost* render_view_host) OVERRIDE;
virtual void DidStartProvisionalLoadForFrame(
@@ -66,6 +66,10 @@ class PrerenderTabHelper
const GURL& validated_url,
content::PageTransition transition_type) OVERRIDE;
+ // Called when the URL of the main frame changed, either when the load
+ // commits, or a redirect happens.
+ void MainFrameUrlDidChange(const GURL& url);
+
// Called when a password form has been submitted.
void PasswordSubmitted(const autofill::PasswordForm& form);

Powered by Google App Engine
This is Rietveld 408576698