Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: chrome/browser/prerender/prerender_tab_helper.cc

Issue 565263005: Remove the use of ProvisionalChangeToMainFrameUrl from prerender code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@redirsupervised
Patch Set: fixing Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/prerender/prerender_tab_helper.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prerender/prerender_tab_helper.cc
diff --git a/chrome/browser/prerender/prerender_tab_helper.cc b/chrome/browser/prerender/prerender_tab_helper.cc
index 8ddd08a0602101cb9e7c2cb703778c485d5b4a76..8c611a4c1e00f40a267bda4ffe63cb5752e109c9 100644
--- a/chrome/browser/prerender/prerender_tab_helper.cc
+++ b/chrome/browser/prerender/prerender_tab_helper.cc
@@ -16,6 +16,7 @@
#include "content/public/browser/navigation_details.h"
#include "content/public/browser/navigation_entry.h"
#include "content/public/browser/render_frame_host.h"
+#include "content/public/browser/resource_request_details.h"
#include "content/public/browser/web_contents.h"
#include "content/public/common/frame_navigate_params.h"
@@ -81,19 +82,13 @@ PrerenderTabHelper::PrerenderTabHelper(
PrerenderTabHelper::~PrerenderTabHelper() {
}
-void PrerenderTabHelper::ProvisionalChangeToMainFrameUrl(
- const GURL& url,
- content::RenderFrameHost* render_frame_host) {
- url_ = url;
- RecordEvent(EVENT_MAINFRAME_CHANGE);
- RecordEventIfLoggedInURL(EVENT_MAINFRAME_CHANGE_DOMAIN_LOGGED_IN, url);
- PrerenderManager* prerender_manager = MaybeGetPrerenderManager();
- if (!prerender_manager)
+void PrerenderTabHelper::DidGetRedirectForResourceRequest(
+ content::RenderViewHost* render_view_host,
+ const content::ResourceRedirectDetails& details) {
+ if (details.resource_type != content::RESOURCE_TYPE_MAIN_FRAME)
return;
- if (prerender_manager->IsWebContentsPrerendering(web_contents(), NULL))
- return;
- ReportTabHelperURLSeenToLocalPredictor(prerender_manager, url,
- web_contents());
+
+ MainFrameUrlDidChange(details.new_url);
}
void PrerenderTabHelper::DidCommitProvisionalLoadForFrame(
@@ -174,6 +169,21 @@ void PrerenderTabHelper::DidStartProvisionalLoadForFrame(
next_load_is_control_prerender_ = false;
next_load_origin_ = ORIGIN_NONE;
}
+
+ MainFrameUrlDidChange(validated_url);
+}
+
+void PrerenderTabHelper::MainFrameUrlDidChange(const GURL& url) {
+ url_ = url;
+ RecordEvent(EVENT_MAINFRAME_CHANGE);
+ RecordEventIfLoggedInURL(EVENT_MAINFRAME_CHANGE_DOMAIN_LOGGED_IN, url);
+ PrerenderManager* prerender_manager = MaybeGetPrerenderManager();
+ if (!prerender_manager)
+ return;
+ if (prerender_manager->IsWebContentsPrerendering(web_contents(), NULL))
+ return;
+ ReportTabHelperURLSeenToLocalPredictor(prerender_manager, url,
+ web_contents());
}
void PrerenderTabHelper::PasswordSubmitted(const autofill::PasswordForm& form) {
« no previous file with comments | « chrome/browser/prerender/prerender_tab_helper.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698