Issue 565213008: Revert of Add a test that uses C++11 features as a compiler canary.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 565213008: Revert of Add a test that uses C++11 features as a compiler canary. (Closed)

Created:
6 years, 3 months ago by mtklein

Modified:
6 years, 3 months ago

Reviewers:
bungeman-skia, mtklein_C

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Revert of Add a test that uses C++11 features as a compiler canary. (patchset #2 id:20001 of https://codereview.chromium.org/568913002/) Reason for revert: nope, nacl and ubuntu local bots (at least) broken Original issue's description: > Add a test that uses C++11 features as a compiler canary. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/86e01df8d1d8848044c3fcc31c1a2008b70fe08c TBR=bungeman@google.com,mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/94c415170b6f62fa80b598fe30bf2f99f0aecf6a

Created: 6 years, 3 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -21 lines)			Patch
M	gyp/common_conditions.gypi	View	4 chunks	+5 lines, -6 lines	0 comments	Download
M	gyp/tests.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	tests/Cpp11Test.cpp	View	1 chunk	+0 lines, -14 lines	0 comments	Download

Total messages: 3 (0 generated)

mtklein

Created Revert of Add a test that uses C++11 features as a compiler canary.

6 years, 3 months ago (2014-09-13 00:07:21 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/565213008/1

6 years, 3 months ago (2014-09-13 00:07:31 UTC) #2

commit-bot: I haz the power

6 years, 3 months ago (2014-09-13 00:07:37 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 94c415170b6f62fa80b598fe30bf2f99f0aecf6a