Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Unified Diff: chrome/browser/resources/print_preview/print_preview.js

Issue 565213005: Make Print Preview elements transitions smoother. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/print_preview/print_preview.js
diff --git a/chrome/browser/resources/print_preview/print_preview.js b/chrome/browser/resources/print_preview/print_preview.js
index 79d7f620e7e92de904146f72fddd765e96787094..b2f110bf77cc031a78ac7daf96b84b3e1ee0ecea 100644
--- a/chrome/browser/resources/print_preview/print_preview.js
+++ b/chrome/browser/resources/print_preview/print_preview.js
@@ -181,7 +181,7 @@ cr.define('print_preview', function() {
* @type {!print_preview.MoreSettings}
* @private
*/
- this.moreSettings_ = new print_preview.MoreSettings([
+ var settingsSections = [
this.destinationSettings_,
this.pageSettings_,
this.copiesSettings_,
@@ -190,7 +190,9 @@ cr.define('print_preview', function() {
this.marginSettings_,
this.colorSettings_,
this.otherOptionsSettings_,
- this.advancedOptionsSettings_]);
+ this.advancedOptionsSettings_];
+ this.moreSettings_ = new print_preview.MoreSettings(
+ this.destinationStore_, settingsSections);
this.addChild(this.moreSettings_);
/**

Powered by Google App Engine
This is Rietveld 408576698