Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 565213005: Make Print Preview elements transitions smoother. (Closed)

Created:
6 years, 3 months ago by Aleksey Shlyapnikov
Modified:
6 years, 3 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make Print Preview elements transitions smoother. BUG=397741 Committed: https://crrev.com/5652d00e5fcf481e95afa24ecf75ba01cf027fa8 Cr-Commit-Position: refs/heads/master@{#294656}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -43 lines) Patch
M chrome/browser/resources/print_preview/print_preview.css View 3 chunks +22 lines, -4 lines 0 comments Download
M chrome/browser/resources/print_preview/print_preview.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/print_preview/print_preview.js View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/resources/print_preview/print_preview_animations.js View 4 chunks +19 lines, -9 lines 0 comments Download
M chrome/browser/resources/print_preview/settings/advanced_options_settings.html View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/resources/print_preview/settings/color_settings.html View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/resources/print_preview/settings/copies_settings.html View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/resources/print_preview/settings/destination_settings.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/print_preview/settings/destination_settings.html View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/resources/print_preview/settings/layout_settings.html View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/resources/print_preview/settings/margin_settings.html View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/resources/print_preview/settings/media_size_settings.html View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/resources/print_preview/settings/more_settings.js View 5 chunks +56 lines, -9 lines 0 comments Download
A + chrome/browser/resources/print_preview/settings/other_options_settings.css View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/resources/print_preview/settings/other_options_settings.html View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/resources/print_preview/settings/page_settings.css View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/resources/print_preview/settings/page_settings.html View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/resources/print_preview/settings/settings_section.js View 3 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Aleksey Shlyapnikov
6 years, 3 months ago (2014-09-12 18:53:05 UTC) #2
Vitaly Buka (NO REVIEWS)
lgtm
6 years, 3 months ago (2014-09-12 19:47:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/565213005/1
6 years, 3 months ago (2014-09-12 19:49:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 341807bc3c4694d020eb3bc7b5446e3ae5200a8b
6 years, 3 months ago (2014-09-12 21:06:22 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 21:13:21 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/5652d00e5fcf481e95afa24ecf75ba01cf027fa8
Cr-Commit-Position: refs/heads/master@{#294656}

Powered by Google App Engine
This is Rietveld 408576698