src/hydrogen-instructions.h - Issue 565183004: Fix the IsTheHole bug.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen-instructions.h

Issue 565183004: Fix the IsTheHole bug. (Closed) Base URL: https://chromium.googlesource.com/external/v8.git@bleeding_edge

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/hydrogen-instructions.h

diff --git a/src/hydrogen-instructions.h b/src/hydrogen-instructions.h

index bcf5492b72390317973a6a2124ca75d3f1912751..ab571470a934c1992eb9659d82e5a2feb77db9cc 100644

--- a/src/hydrogen-instructions.h

+++ b/src/hydrogen-instructions.h

@@ -3593,7 +3593,8 @@ class HConstant FINAL : public HTemplateInstruction<0> {

if (HasDoubleValue() && FixedDoubleArray::is_the_hole_nan(double_value_)) {

return true;

}

- return object_.IsKnownGlobal(isolate()->heap()->the_hole_value());

+ return object_.IsInitialized() &&

+ object_.IsKnownGlobal(isolate()->heap()->the_hole_value());

}

bool HasNumberValue() const { return has_double_value_; }

int32_t NumberValueAsInteger32() const {

« no previous file with comments | « no previous file | no next file » | no next file with comments »