Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 565183004: Fix the IsTheHole bug. (Closed)

Created:
6 years, 3 months ago by chunyang.dai
Modified:
6 years, 3 months ago
Reviewers:
Weiliang, mvstanton
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/external/v8.git@bleeding_edge
Project:
v8
Visibility:
Public.

Description

Fix the IsTheHole bug. For Double constant of non nan, object_ may be uninitialized. (This patch comes from weiliang.lin@intel.com ) BUG= R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24007

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/hydrogen-instructions.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
chunyang.dai
hello. Mvstanton. PTAL. thanks.
6 years, 3 months ago (2014-09-17 12:00:33 UTC) #3
mvstanton
lgtm. Should I land that for you? Thx, --Michael
6 years, 3 months ago (2014-09-17 12:17:09 UTC) #4
chunyang.dai
hello,Michael please help to land it. thanks
6 years, 3 months ago (2014-09-17 13:34:46 UTC) #5
mvstanton
6 years, 3 months ago (2014-09-17 14:29:08 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24007 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698