Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 565153002: Disable Shim_TestEventName as it is super flaky on Chrome OS. (Closed)

Created:
6 years, 3 months ago by engedy
Modified:
6 years, 3 months ago
Reviewers:
Mike West
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Disable Shim_TestEventName as it is super flaky on Chrome OS. BUG=413618 TBR=asargent@chromium.org Committed: https://crrev.com/43e46fbf23d0454f5d0aee1bb8a74a4bae87e7f5 Cr-Commit-Position: refs/heads/master@{#294590}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M chrome/browser/apps/web_view_browsertest.cc View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
engedy
Mike, can you PTAL?
6 years, 3 months ago (2014-09-12 12:37:23 UTC) #2
Mike West
You're a sheriff. Don't ask for reviews; revert patches. :) LGTM.
6 years, 3 months ago (2014-09-12 13:07:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/565153002/1
6 years, 3 months ago (2014-09-12 13:12:51 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/10600)
6 years, 3 months ago (2014-09-12 13:20:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/565153002/1
6 years, 3 months ago (2014-09-12 13:24:53 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as d9296deee384bdf6ebaf41499140f2126492ea15
6 years, 3 months ago (2014-09-12 15:15:51 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 15:18:13 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/43e46fbf23d0454f5d0aee1bb8a74a4bae87e7f5
Cr-Commit-Position: refs/heads/master@{#294590}

Powered by Google App Engine
This is Rietveld 408576698