Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 56513005: Add stable experiment IDs for Android NTP finch trials. (Closed)

Created:
7 years, 1 month ago by Ted C
Modified:
7 years, 1 month ago
CC:
chromium-reviews, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org
Visibility:
Public.

Description

Add stable experiment IDs for Android NTP finch trials. Renames previous constants to make it clearer they are for Dev/Beta. BUG=251830 NOTRY=true R=asvitkine@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232848

Patch Set 1 #

Patch Set 2 : Update incorrect range comment #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -8 lines) Patch
M chrome/common/metrics/variations/variation_ids.h View 1 1 chunk +14 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Ted C
PTAL
7 years, 1 month ago (2013-11-01 21:50:33 UTC) #1
Alexei Svitkine (slow)
LGTM
7 years, 1 month ago (2013-11-04 15:54:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedchoc@chromium.org/56513005/20001
7 years, 1 month ago (2013-11-04 15:55:31 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 1 month ago (2013-11-04 16:10:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedchoc@chromium.org/56513005/20001
7 years, 1 month ago (2013-11-04 17:48:38 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=218703
7 years, 1 month ago (2013-11-04 21:50:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedchoc@chromium.org/56513005/20001
7 years, 1 month ago (2013-11-04 22:13:22 UTC) #7
Ted C
7 years, 1 month ago (2013-11-05 00:22:35 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 manually as r232848 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698