src/mips/full-codegen-mips.cc - Issue 565093002: Reland "Change the order of arguments of the (One|Two)ByteSeqStringSetChar intrinsic."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/mips/full-codegen-mips.cc

Issue 565093002: Reland "Change the order of arguments of the (One|Two)ByteSeqStringSetChar intrinsic." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Fix typo Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/mips/full-codegen-mips.cc

diff --git a/src/mips/full-codegen-mips.cc b/src/mips/full-codegen-mips.cc

index 36c0b52bcd1475000f5d1aee29a3ed8c5f6e132f..e679a29e51c9453b1afbb67cff16e28bb10e4283 100644

--- a/src/mips/full-codegen-mips.cc

+++ b/src/mips/full-codegen-mips.cc

@@ -3435,9 +3435,9 @@ void FullCodeGenerator::EmitOneByteSeqStringSetChar(CallRuntime* expr) {

- VisitForStackValue(args->at(1)); // index

- VisitForStackValue(args->at(2)); // value

- VisitForAccumulatorValue(args->at(0)); // string

+ VisitForStackValue(args->at(0)); // index

+ VisitForStackValue(args->at(1)); // value

+ VisitForAccumulatorValue(args->at(2)); // string

__ Pop(index, value);

if (FLAG_debug_code) {

@@ -3472,9 +3472,9 @@ void FullCodeGenerator::EmitTwoByteSeqStringSetChar(CallRuntime* expr) {