Reland "Change the order of arguments of the (One|Two)ByteSeqStringSetChar intrinsic."

src/arm64/full-codegen-arm64.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #if V8_TARGET_ARCH_ARM64
 
 #include "src/code-factory.h"
 #include "src/code-stubs.h"
@@ skipping 3113 matching lines @@
 
 void FullCodeGenerator::EmitOneByteSeqStringSetChar(CallRuntime* expr) {
   ZoneList<Expression*>* args = expr->arguments();
   DCHECK_EQ(3, args->length());
 
   Register string = x0;
   Register index = x1;
   Register value = x2;
   Register scratch = x10;
 
-  VisitForStackValue(args->at(1));        // index
-  VisitForStackValue(args->at(2));        // value
-  VisitForAccumulatorValue(args->at(0));  // string
+  VisitForStackValue(args->at(0));        // index
+  VisitForStackValue(args->at(1));        // value
+  VisitForAccumulatorValue(args->at(2));  // string
   __ Pop(value, index);
 
   if (FLAG_debug_code) {
     __ AssertSmi(value, kNonSmiValue);
     __ AssertSmi(index, kNonSmiIndex);
     static const uint32_t one_byte_seq_type = kSeqStringTag | kOneByteStringTag;
     __ EmitSeqStringSetCharCheck(string, index, kIndexIsSmi, scratch,
                                  one_byte_seq_type);
   }
 
   __ Add(scratch, string, SeqOneByteString::kHeaderSize - kHeapObjectTag);
   __ SmiUntag(value);
   __ SmiUntag(index);
   __ Strb(value, MemOperand(scratch, index));
   context()->Plug(string);
 }
 
 
 void FullCodeGenerator::EmitTwoByteSeqStringSetChar(CallRuntime* expr) {
   ZoneList<Expression*>* args = expr->arguments();
   DCHECK_EQ(3, args->length());
 
   Register string = x0;
   Register index = x1;
   Register value = x2;
   Register scratch = x10;
 
-  VisitForStackValue(args->at(1));        // index
-  VisitForStackValue(args->at(2));        // value
-  VisitForAccumulatorValue(args->at(0));  // string
+  VisitForStackValue(args->at(0));        // index
+  VisitForStackValue(args->at(1));        // value
+  VisitForAccumulatorValue(args->at(2));  // string
   __ Pop(value, index);
 
   if (FLAG_debug_code) {
     __ AssertSmi(value, kNonSmiValue);
     __ AssertSmi(index, kNonSmiIndex);
     static const uint32_t two_byte_seq_type = kSeqStringTag | kTwoByteStringTag;
     __ EmitSeqStringSetCharCheck(string, index, kIndexIsSmi, scratch,
                                  two_byte_seq_type);
   }
 
@@ skipping 1732 matching lines @@
   return previous_;
 }
 
 
 #undef __
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_TARGET_ARCH_ARM64