Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 565063003: Eliminate SVGTextRunRenderingContext::m_activePaintingResource (Closed)

Created:
6 years, 3 months ago by fs
Modified:
6 years, 3 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, rwlbuis, Stephen Chennney, rune+blink
Project:
blink
Visibility:
Public.

Description

Eliminate SVGTextRunRenderingContext::m_activePaintingResource With geometry being emitted independently from the paint server setup, it becomes possible to just rely on the current state of the GC when painting SVG font text (which in turn allows us to make stricter assumptions with more confidence elsewhere.) Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182153

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -55 lines) Patch
M Source/core/rendering/svg/SVGInlineTextBox.cpp View 1 5 chunks +2 lines, -15 lines 0 comments Download
M Source/core/rendering/svg/SVGTextRunRenderingContext.h View 2 chunks +0 lines, -10 lines 0 comments Download
M Source/core/rendering/svg/SVGTextRunRenderingContext.cpp View 3 chunks +3 lines, -30 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
fs
Meddling with mostly disabled code is a bit scary, but... Tested by enabling SVGFontsOnNonGDIPlatforms and ...
6 years, 3 months ago (2014-09-16 13:59:29 UTC) #2
pdr.
On 2014/09/16 13:59:29, fs wrote: > Meddling with mostly disabled code is a bit scary ...
6 years, 3 months ago (2014-09-16 18:40:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/565063003/1
6 years, 3 months ago (2014-09-17 08:08:49 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/15351)
6 years, 3 months ago (2014-09-17 08:20:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/565063003/20001
6 years, 3 months ago (2014-09-17 08:29:58 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/27423)
6 years, 3 months ago (2014-09-17 10:01:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/565063003/20001
6 years, 3 months ago (2014-09-17 11:46:13 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 13:09:24 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 182153

Powered by Google App Engine
This is Rietveld 408576698