DescriptionSimplify test locales in Mac's ui_unittests Framework (take 2)
Mac creates a mini-framework in `ui_unittests Framework` so that ui
tests can get a resource bundle without depending on the Chrome
framework.
The way it generated locale information was causing build flakes since
two instances of repack_locales.py could be writing to
out/../gen/repack. Tests always use en-US, so instead just repack the
strings made for ui_test.pak to en.lproj/locale.pak and roll it into the
mini-framework bundle.
Note we can't simply copy ui_test.pak because Mac system libraries will
annoy valgrind with leaks when they encounter unexpected things in it.
BUG=410468, 413034
Committed: https://crrev.com/9573ca904f9d465a6be78629cc04a0aac52a36fb
Cr-Commit-Position: refs/heads/master@{#294774}
Patch Set 1 : Baseline from crrev/552963002 #Patch Set 2 : delta from earlier review - just repack the strings #Patch Set 3 : Corresponding GN change - seems to work #
Messages
Total messages: 10 (4 generated)
|