Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 565063002: Simplify test locales in Mac's ui_unittests Framework (take 2) (Closed)

Created:
6 years, 3 months ago by tapted
Modified:
6 years, 3 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, oshima+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Simplify test locales in Mac's ui_unittests Framework (take 2) Mac creates a mini-framework in `ui_unittests Framework` so that ui tests can get a resource bundle without depending on the Chrome framework. The way it generated locale information was causing build flakes since two instances of repack_locales.py could be writing to out/../gen/repack. Tests always use en-US, so instead just repack the strings made for ui_test.pak to en.lproj/locale.pak and roll it into the mini-framework bundle. Note we can't simply copy ui_test.pak because Mac system libraries will annoy valgrind with leaks when they encounter unexpected things in it. BUG=410468, 413034 Committed: https://crrev.com/9573ca904f9d465a6be78629cc04a0aac52a36fb Cr-Commit-Position: refs/heads/master@{#294774}

Patch Set 1 : Baseline from crrev/552963002 #

Patch Set 2 : delta from earlier review - just repack the strings #

Patch Set 3 : Corresponding GN change - seems to work #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -27 lines) Patch
M ui/base/ui_base_tests_bundle.gypi View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M ui/resources/BUILD.gn View 1 2 3 chunks +25 lines, -8 lines 0 comments Download
M ui/resources/ui_resources.gyp View 1 2 1 chunk +16 lines, -16 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
tapted
Hi Avi, it's take 2 - please take a look. I've tested locally on my ...
6 years, 3 months ago (2014-09-12 08:04:11 UTC) #4
tapted
On 2014/09/12 08:04:11, tapted wrote: > Hi Avi, it's take 2 - please take a ...
6 years, 3 months ago (2014-09-12 09:42:59 UTC) #5
Avi (use Gerrit)
LGTM
6 years, 3 months ago (2014-09-12 15:52:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/565063002/80001
6 years, 3 months ago (2014-09-15 00:10:15 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:80001) as eb6a399d4cc1972c153377147707870cc12f9525
6 years, 3 months ago (2014-09-15 01:16:22 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 01:19:39 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9573ca904f9d465a6be78629cc04a0aac52a36fb
Cr-Commit-Position: refs/heads/master@{#294774}

Powered by Google App Engine
This is Rietveld 408576698