Issue 565047: * Add the partial context snapshot to the VM executable if...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 565047: * Add the partial context snapshot to the VM executable if... (Closed)

Created:
10 years, 10 months ago by Erik Corry

Modified:
10 years, 10 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/experimental/partial_snapshots/

Visibility:
Public.

Description

* Add the partial context snapshot to the VM executable if running with snapshots. * Create contexts from partial snapshot if they contain no extensions or global object templates. Add counters to track when this happens. * Remove debugging (logging code). * Some lint fixes. Committed: http://code.google.com/p/v8/source/detail?r=3792

Patch Set 1 #

Total comments: 1

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+194 lines, -53 lines)			Patch
M	include/v8.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/api.cc	View	2 chunks	+32 lines, -0 lines	1 comment	Download
M	src/bootstrapper.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/bootstrapper.cc	View	2 chunks	+14 lines, -1 line	0 comments	Download
M	src/frames.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	src/heap.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/mksnapshot.cc	View	5 chunks	+93 lines, -10 lines	0 comments	Download
M	src/serialize.h	View	4 chunks	+0 lines, -25 lines	0 comments	Download
M	src/serialize.cc	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	src/snapshot.h	View	2 chunks	+13 lines, -1 line	0 comments	Download
M	src/snapshot-common.cc	View	1 chunk	+20 lines, -0 lines	0 comments	Download
M	src/snapshot-empty.cc	View	1 chunk	+11 lines, -1 line	0 comments	Download
M	src/v8-counters.h	View	1 chunk	+6 lines, -1 line	0 comments	Download
M	src/v8threads.cc	View	5 chunks	+0 lines, -5 lines	0 comments	Download
M	test/cctest/test-serialize.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

10 years, 10 months ago (2010-02-04 07:39:05 UTC) #2

LGTM, except for the counter updating.

http://codereview.chromium.org/565047/diff/1/4
File src/api.cc (right):

http://codereview.chromium.org/565047/diff/1/4#newcode2775
src/api.cc:2775: i::Counters::contexts_created_by_snapshot.Increment();
This context is not created from the snapshot, right?

Expand Messages | Collapse Messages