Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1311)

Issue 565027: Chromium side fix for new layout tests in websocket/test/cookies/ (Closed)

Created:
10 years, 10 months ago by ukai
Modified:
9 years, 7 months ago
CC:
chromium-reviews, PaweĊ‚ Hajdan Jr., darin (slow to review), dpranke+watch_chromium.org, pam+watch_chromium.org
Visibility:
Public.

Description

Chromium side fix for new layout tests in websocket/test/cookies/ pywebsocket 0.4.8 introduced -x option to specify cgi directory and it is required to run layout tests in websocket/test/cookies introduced by https://bugs.webkit.org/show_bug.cgi?id=34289 BUG=none TEST=none

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M webkit/tools/layout_tests/webkitpy/layout_tests/layout_package/websocket_server.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ukai
Will land this once https://bugs.webkit.org/show_bug.cgi?id=34289 is landed and rolled into chromium.
10 years, 10 months ago (2010-02-03 02:04:33 UTC) #1
tyoshino (SeeGerritForStatus)
LGTM
10 years, 10 months ago (2010-02-03 03:09:48 UTC) #2
Yuta Kitamura
LGTM too.
10 years, 10 months ago (2010-02-03 03:59:32 UTC) #3
Dirk Pranke
10 years, 10 months ago (2010-02-03 04:19:15 UTC) #4
Please let me know when it is okay to merge this fix into the upstream
version of the code.

-- Dirk

On Tue, Feb 2, 2010 at 7:59 PM,  <yutak@chromium.org> wrote:
> LGTM too.
>
> http://codereview.chromium.org/565027
>

Powered by Google App Engine
This is Rietveld 408576698