Issue 565027: Chromium side fix for new layout tests in websocket/test/cookies/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 565027: Chromium side fix for new layout tests in websocket/test/cookies/ (Closed)

Created:
10 years, 10 months ago by ukai

Modified:
9 years, 7 months ago

Reviewers:
tyoshino (SeeGerritForStatus), Yuta Kitamura

CC:
chromium-reviews, Paweł Hajdan Jr., darin (slow to review), dpranke+watch_chromium.org, pam+watch_chromium.org

Visibility:
Public.

Description

Chromium side fix for new layout tests in websocket/test/cookies/ pywebsocket 0.4.8 introduced -x option to specify cgi directory and it is required to run layout tests in websocket/test/cookies introduced by https://bugs.webkit.org/show_bug.cgi?id=34289 BUG=none TEST=none

Patch Set 1 #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	webkit/tools/layout_tests/webkitpy/layout_tests/layout_package/websocket_server.py	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ukai

Will land this once https://bugs.webkit.org/show_bug.cgi?id=34289 is landed and rolled into chromium.

10 years, 10 months ago (2010-02-03 02:04:33 UTC) #1

Dirk Pranke

10 years, 10 months ago (2010-02-03 04:19:15 UTC) #4

Please let me know when it is okay to merge this fix into the upstream
version of the code.

-- Dirk

On Tue, Feb 2, 2010 at 7:59 PM,  <yutak@chromium.org> wrote:
> LGTM too.
>
> http://codereview.chromium.org/565027
>

Expand Messages | Collapse Messages